1648879 - SWGL is upside down on Windows

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Bert Peers [:bpeers]]

Attachment: swgl_windows_upside_down.PNG

Tested on unmodified branches/default/tip with WR enabled, the browser is upside down.
Hit detection seems to use the right-side-up image, ie. you still need to hover over elements in the upper left to see them highlight in the lower left.

Comment 1

[Bert Peers [:bpeers]]

Tested with a clean profile just to be sure:

1. ./mach run --profile SWGL_TEST
2. about:config -> add gfx.webrender.software.true
3. close browser
4. ./mach run --profile SWGL_TEST -> upside down :|

Comment 2

[Bert Peers [:bpeers]]

I can repro so I'll take it.

Comment 3

[Bert Peers [:bpeers]]

Attachment: Bug 1648879 - SWGL on Windows upside down r=lsalzman

Fix ODR violation: type of GLboolean must match gleam, else the unsafe{}
glue code will corrupt the parameters (and go out of bounds in
GetBooleanv). "Composite" was getting a garbage value for "flip".

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43a6b9c2550c
SWGL on Windows upside down r=lsalzman

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/43a6b9c2550c