1648915 - https://phabricator.services.mozilla.com/D81358 revision can neither be download nor applied with |moz-phab patch|: RuntimeException: Uninitialized string offset: 0

Status: RESOLVED DUPLICATE of bug 1646831

(Conduit :: moz-phab, defect, P2)

Description

[André Bargull [:anba]]

+++ This bug was initially created as a clone of Bug #1644822 +++

https://phabricator.services.mozilla.com/D81358?download=true

lists:

PhutilAggregateException
Encountered a processing exception, then another exception when trying to build a response for the first exception.

• RuntimeException: array_walk_recursive() expects parameter 1 to be array, null given
• RuntimeException: Uninitialized string offset: 0
  RuntimeException
  array_walk_recursive() expects parameter 1 to be array, null given
  RuntimeException
  Uninitialized string offset: 0

The last error message was also shown for moz-phab patch D81358 --apply-to . --skip-dependenices. The patch and its stack have been landed manually.

---

Also uploaded as <https://phabricator.services.mozilla.com/D81438?download=true. For that upload I didn't use --lesscontext to see if it makes any difference.

---

This issue blocks updating test262 (bug 1648757) for the SpiderMonkey team.

Comment 1

[Piotr Zalewa [:zalun]]

While watching the revision Phabricator displays a This very large diff affects more than 1,000 files. Use the Changeset List to browse changes.

moz-phab patch D81358 --raw --skip-dependencies is showing changes for 2 files only - js/src/shell/js.cpp and js/src/tests/test262-update.py b/js/src/tests/test262-update.py then it fails with Uninitialized string offset: 0 on retrieving the https://phabricator.services.mozilla.com/api/differential.getrawdiff {'diffID': 303322}.

Where there any empty files added?

Comment 2

[André Bargull [:anba]]

(In reply to Piotr Zalewa [:zalun] from comment #1)

While watching the revision Phabricator displays a This very large diff affects more than 1,000 files. Use the Changeset List to browse changes.

The changeset is an automated update for test262, which includes more than 200 commits. Therefore there's a large number of modified files.

moz-phab patch D81358 --raw --skip-dependencies is showing changes for 2 files only - js/src/shell/js.cpp and js/src/tests/test262-update.py b/js/src/tests/test262-update.py then it fails with Uninitialized string offset: 0 on retrieving the https://phabricator.services.mozilla.com/api/differential.getrawdiff {'diffID': 303322}.

These two files are only modified in the parent commits:

• https://phabricator.services.mozilla.com/D81324
• https://phabricator.services.mozilla.com/D81325

Where there any empty files added?

Yes, some empty files added through the update process. (The jsreftest test suite loads per each directory it processes a "shell.js" and a "browser.js" file, which both may be empty when no shell- resp. brower-specific actions need to be taken.)

Comment 3

[Piotr Zalewa [:zalun]]

Another revision: https://phabricator.services.mozilla.com/D80349
From Riot #Conduit channel:

Kwan
championshuttler: Interesting. I get that exception if I'm not logged in, but it loads okay if I am. I'm also reading a completely empty diff, so it might be something to do with that

I'm not resolving as a duplicate of bug 1646831 yet. Phabricator behavior is different.

Comment 4

[Ian Moody [:Kwan] (UTC+0)]

querydiffs for diff ID 303322 from D81358 is showing 55 files as having the "corpus": "" issue from bug 1646831, and they are indeed all shell.js or browser.js files, so re-uploading with either moz-phab submit --arc or using the latest master of moz-phab should be enough to make it landable.

I think D80349 is probably a separate bug (since diff ID 303468 has no files at all just "changes": []), and this is a dupe of bug 1646831.

Comment 5

[André Bargull [:anba]]

Great! I've just re-uploaded with D81358 using --arc and it appears to work correctly! (Using --arc also seems to side-step bug 1635298, which is nice, because I didn't had to wait two hours for the upload of D81358. :-)