1649099 - Add WPTs for testing the effect on activeElement of the containing doc when calling .focus() and .blur() on an OOP iframe

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, task, P2)

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1649099 - Add WPTs for testing the effect on activeElement of the containing doc when calling .focus() and .blur() on an OOP iframe.

Comment 2

[Henri Sivonen (:hsivonen)]

As a surprise, the different-site case passes in Fission. I'll use Pernosco to figure out why.

Comment 3

[Henri Sivonen (:hsivonen)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4390a08ee5b7de8ab2d8b6e075f90961e63a9378

Comment 4

[Henri Sivonen (:hsivonen)]

(In reply to Henri Sivonen (:hsivonen) from comment #2)

As a surprise, the different-site case passes in Fission. I'll use Pernosco to figure out why.

Things are OK after onload. Need to write more tests for the case before onload.

Comment 5

[Henri Sivonen (:hsivonen)]

Here are the cases that differ between Chrome and Firefox:

/focus/activeelement-after-immediately-focusing-different-site-iframe-contentwindow.html

Chrome
"outerparser,activeElement:BODY,willfocusiframe,didfocusiframe,activeElement:IFRAME,willbluriframe,didbluriframe,activeElement:IFRAME,willspineventloop,"

Firefox without Fission
"outerparser,activeElement:BODY,willfocusiframe,didfocusiframe,activeElement:IFRAME,willbluriframe,didbluriframe,activeElement:IFRAME,willspineventloop,innerbodyfocus,"

Firefox with Fission
"outeronload,activeElement:BODY,willfocusiframe,didfocusiframe,activeElement:BODY,willbluriframe,didbluriframe,activeElement:BODY,willspineventloop,innerbodyfocus,"

/focus/activeelement-after-immediately-focusing-different-site-iframe.html

Chrome
"outerparser,activeElement:BODY,willfocusiframe,didfocusiframe,activeElement:IFRAME,willbluriframe,didbluriframe,activeElement:BODY,willspineventloop,"

Firefox without Fission
"outerparser,activeElement:BODY,willfocusiframe,didfocusiframe,activeElement:BODY,willbluriframe,didbluriframe,activeElement:BODY,willspineventloop,"

Firefox with Fission
"outerparser,activeElement:BODY,willfocusiframe,didfocusiframe,activeElement:BODY,willbluriframe,didbluriframe,activeElement:BODY,willspineventloop,"

/focus/activeelement-after-immediately-focusing-same-site-iframe-contentwindow.html

Chrome
"outerparse,activeElement:BODY,willfocusiframe,didfocusiframe,activeElement:IFRAME,willbluriframe,didbluriframe,activeElement:IFRAME,willspineventloop,"

Firefox without Fission
"outerparse,activeElement:BODY,willfocusiframe,didfocusiframe,activeElement:IFRAME,willbluriframe,didbluriframe,activeElement:IFRAME,willspineventloop,innerbodyfocus,"

Firefox with Fission
"outerparse,activeElement:BODY,willfocusiframe,didfocusiframe,activeElement:IFRAME,willbluriframe,didbluriframe,activeElement:IFRAME,willspineventloop,innerbodyfocus,"

/focus/activeelement-after-immediately-focusing-same-site-iframe.html

Chrome
"outerparse,activeElement:BODY,willfocusiframe,didfocusiframe,activeElement:IFRAME,willbluriframe,didbluriframe,activeElement:BODY,willspineventloop,"

Firefox without Fission
"outerparse,activeElement:BODY,willfocusiframe,didfocusiframe,activeElement:BODY,willbluriframe,didbluriframe,activeElement:BODY,willspineventloop,"

Firefox with Fission
"outerparse,activeElement:BODY,willfocusiframe,didfocusiframe,activeElement:BODY,willbluriframe,didbluriframe,activeElement:BODY,willspineventloop,"

Comment 6

[Henri Sivonen (:hsivonen)]

(In reply to Henri Sivonen (:hsivonen) from comment #5)

Here are the cases that differ between Chrome and Firefox:

The primary observation is that Chrome's results don't differ between same-site and different-site. That seems like a good sign.

contentWindow

Different-site in Firefox via contentWindow differs between Fission and non-Fission. (Do sites actually care about contentWindow? We have a pre-existing unit test that does.)

The document inside the iframe fires a focus event in Firefox but not in Chrome. Blur isn't observable in either.

Element

Firefox fails to focus with or without Fission even though Chrome focuses.

annevk, any thoughts on the focus event observability difference in the contentWindow case?

Comment 7

[Anne (:annevk)]

Nothing concrete unfortunately. I think our focus should be on getting the browsers, tests, and the standard in alignment. We should not have behavior differences between Fission and non-Fission (same-origin vs cross-origin or same-site vs cross-site differences are okay though).

Comment 8

[Neha Kochar [:neha]]

We should do this as soon as possible in M6.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ca78eb969aa
Add WPTs for testing the effect on activeElement of the containing doc when calling .focus() and .blur() on an OOP iframe. r=jgraham

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/25456 for changes under testing/web-platform/tests

Comment 11

[Razvan Maries]

Backed out for perma failures.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=S6OjJXD8ToqimpFJilV_GA.0&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=android%2C7.0%2Cx86-64%2Copt%2Cweb%2Cplatform%2Ctests%2Ctest-android-em-7.0-x86_64%2Fopt-geckoview-web-platform-tests-e10s%2Cwpt2&revision=5ca78eb969aa16420f049f4a5a7ba95b94b783c1

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315232224&repo=autoland&lineNumber=4483

Backout: https://hg.mozilla.org/integration/autoland/rev/e39008a3c702b4fb741c03cc0b562d1723b92bd5

Comment 12

[Henri Sivonen (:hsivonen)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=22e074c1dbbfb399ef634461de3f065fa5742159

Comment 13

[Henri Sivonen (:hsivonen)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f796e9c72bcaf27447270f51aadcd2f5418a8215

Comment 14

[Henri Sivonen (:hsivonen)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2da1946f6994bb9e537dce65c31897b54851e185

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05cc29ef24ba
Add WPTs for testing the effect on activeElement of the containing doc when calling .focus() and .blur() on an OOP iframe. r=jgraham

Comment 16

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/05cc29ef24ba

Comment 17

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot