1649272 - app link test crashes if no android-install-apk is provided

Status: RESOLVED FIXED

(Testing :: mozperftest, defect)

Description

[Andrew Creskey [:acreskey]]

When running the applink without providing an android-install-apk path (for example, if the browser is already installed), it will crash looking up the first item in the empty android_install_apk list.

https://searchfox.org/mozilla-central/rev/5a4aaccb28665807a6fd49cf48367d47fbb5a19a/testing/performance/hooks_applink.py#31

  File "/Users/acreskey/dev/src/mozilla-central/python/mozperftest/mozperftest/mach_commands.py", line 73, in run_perftest
    run_tests(mach_cmd=self, **kwargs)
  File "/Users/acreskey/dev/src/mozilla-central/python/mozperftest/mozperftest/runner.py", line 114, in run_tests
    hooks.run("before_iterations", kwargs)
  File "/Users/acreskey/dev/src/mozilla-central/python/mozperftest/mozperftest/hooks.py", line 58, in run
    return getattr(self._hooks, name)(*args, **kw)
  File "testing/performance/hooks_applink.py", line 31, in before_iterations
    if "fenix_nightlysim_multicommit" not in kw.get("android_install_apk")[0]:

It should handle this gracefully.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:tarek, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[sraturi]

:acreskey, I'm wondering what the expected behavior is for the following case

1. The apk is not provided but the apk is already installed on the device.
   use the existing apk?

2. The apk is not provided and there is no apk installed on the device

Comment 3

[sraturi]

Attachment: Bug 1649272: added a nullcheck for android_intall_apk list r?acreskey

Comment 4

[Andrew Creskey [:acreskey]]

(In reply to sraturi from comment #2)

:acreskey, I'm wondering what the expected behavior is for the following case

1. The apk is not provided but the apk is already installed on the device.
   use the existing apk?

That's right -- ./mach perftest should already do that.

2. The apk is not provided and there is no apk installed on the device

I believe ./mach perftest already correctly reports this error. (If it doesn't please log it).

Comment 5

[sraturi]

Attachment: Bug 1649272: added a nullcheck for android_intall_apk list r?acreskey

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a66fbaa1eab2
added a nullcheck for android_intall_apk list r=acreskey,tarek,sparky

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/a66fbaa1eab2