1649350 - Don't clear BrowsingContext::CurrentLoadIdentifier until the load fully completes

Status: NEW

(Core :: DOM: Navigation, task, P3)

Description

[Matt Woodrow (:mattwoodrow)]

CurrentLoadIdentifier on BrowsingContext currently gets cleared when DocumentLoadListener switches out for the 'real' transport channel (which happens once we get a response).

For the purposes of preventing form double submissions, it might be better to have the value preserved until we finish loading the resulting Document.

I think this also could be useful for synthesizing nsIWebProgressListener events (bug 1647554) from the parent process, since we also want the onStateChange(STATE_STOP) event to be fired once the Document is loaded.

I'll attach a WIP that does this, and tightly associates the mCurrentLoad (DocumentLoadListener*) in the CanonicalBrowsingContext with the CurrentLoadIdentifier.
We should be able to use a DidSet implementation to emit web progress events, using the current load object to provide the nsIRequest state.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1649350 - Try having separate pending and current loads, and don't clear current until the docshell has entirely finished loading