1649356 - Cleanup inconsistencies in taskgraph schemas.

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, defect)

Comment 1

[Tom Prince [:tomprince]]

Attachment: Bug 1649356: [taskgraph] Don't have unused `depname` key in release transforms; r?Callek

We don't ever set depname in any of the kinds that use these transforms.
Since we don't apply default values in schemas, Required(..., default=...)
behaves equivalently to Optional(...), so we can just remove these options.

Comment 2

[Tom Prince [:tomprince]]

Attachment: Bug 1649356: [taskgraph] We do not honour voluptuous `default` values, so don't specify them; r?Callek

Comment 3

[Tom Prince [:tomprince]]

Attachment: Bug 1649356: [taskgraph] `optionally_keyed_by` takes multiple fields to key by; r?Callek

Comment 4

[Tom Prince [:tomprince]]

Attachment: Bug 1649356: [taskgraph] Don't use `Schema(..., required=True)`; r?ahal

This is the only place where we override the default of required=False.
Change it to match the rest of the schemas, so as not to confuse people who
don't happen to notice the final line of the scehma.

Comment 5

[Tom Prince [:tomprince]]

Attachment: Bug 1649356: [taskgraph] Enforce schema identifier restrictions for source_test schema; r?ahal

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3661d7d61d04
[taskgraph] Don't have unused `depname` key in release transforms; r=Callek
https://hg.mozilla.org/integration/autoland/rev/7bb059510517
[taskgraph] We do not honour voluptuous `default` values, so don't specify them; r=Callek
https://hg.mozilla.org/integration/autoland/rev/0b0cded20064
[taskgraph] `optionally_keyed_by` takes multiple fields to key by; r=Callek
https://hg.mozilla.org/integration/autoland/rev/4ffb1ac48cea
[taskgraph] Don't use `Schema(..., required=True)`; r=ahal
https://hg.mozilla.org/integration/autoland/rev/e6d6bbdb8334
[taskgraph] Enforce schema identifier restrictions for source_test schema; r=ahal

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/3661d7d61d04
https://hg.mozilla.org/mozilla-central/rev/7bb059510517
https://hg.mozilla.org/mozilla-central/rev/0b0cded20064
https://hg.mozilla.org/mozilla-central/rev/4ffb1ac48cea
https://hg.mozilla.org/mozilla-central/rev/e6d6bbdb8334