1649407 - The zap image partially covers the “welcome-text” on the “Import” slide from the “about:welcome” page on Windows

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Robert Martin [:romartin], Ecosystem QA]

Attachment: The zap svg covers "Firefox" word from the "welcome-text"

[Notes]:

• There is not enough distance between the zap image and the “welcome-text” on the other “about:welcome” slides.

[Affected Versions]:

• Firefox Beta 79.0a1 (Build ID: 20200629224419)
• Firefox Nightly 80.0a1 (Build ID: 20200629154604)

[Affected Platforms]:

• Windows 10 (x64)

[Prerequisites]:

• Have a new profile created.
• Have the value of the browser.aboutwelcome.overrideContent pref set to {"id": "multi-stage-welcome-importable-theme","template": "multistage","screens": [{"id": "AW_GET_STARTED","order": 0,"content": {"zap": true,"title": { "string_id": "onboarding-multistage-welcome-header" }, "subtitle": "The fast, safe, and private browser that's backed by a non-profit.", "primary_button": {"label": "Start Setup","action":{"navigate": true}}, "secondary_button": {"text": "Have an account?", "label": "Sign in","position": "top", "action":{"type": "OPEN_URL","addFlowParams": true, "data":{"args": "https://accounts.firefox.com/?service=sync&action=email&context=fx_desktop_v3&entrypoint=activity-stream-firstrun&style=trailhead","where": "current"}}}}},{"id": "AW_IMPORT_SETTINGS","order": 1,"content": {"zap": true,"title": "Import your passwords, bookmarks,\u00a0and more","subtitle": "Coming from another browser? It's easy to bring everything to Firefox.","tiles": {"type": "topsites"}, "primary_button": {"label": "Start Import", "action":{"type": "SHOW_MIGRATION_WIZARD","navigate": true}},"secondary_button": {"label": "Not now","action":{"navigate": true}}}},{"id": "AW_CHOOSE_THEME","order": 2,"content": {"zap": true, "title": "Choose a look","subtitle": "Personalize Firefox with a theme.","tiles": {"type": "theme","action": {"theme": "<event>"}, "data": [{"theme": "light", "label": "Light"}, {"theme": "dark", "label": "Dark"}]}, "primary_button": {"label": "Save Theme", "action":{"navigate": true}},"secondary_button": {"label": "Not now","action":{"theme": "default","navigate": true}}}}]}.

[Steps to reproduce]:

1. Start the Firefox Browser with the profile from prerequisites.
2. Navigate to the “about:welcome” page.
3. Click the “Start Setup” button and observe the string underneath the zap image.

[Expected results]:

• The zap image does not cover the “welcome-text” string.

[Actual results]:

• The zap image partially covers the “Firefox” word from the “welcome-text” string.

[Additional Notes]:

• The issue is not reproducible for the following displays:
  • MacBook Pro Retina, 13”, early 2015.
  • iMac, 21.5”, late 2013.
  • Ubuntu Linux 18.04 (x64) actual machine as well as a VM.
  • Linux MX 4.19 (VM) (x64).
• Attached a screen-shot with the issue.

Comment 1

[Tim Spurway [:tspurway]]

[Tracking Requested - why for this release]: this is a small CSS change that would be great to get into beta

Comment 2

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1649407 - Fix zap overlap on import screen in windows

Comment 3

[Punam Dahiya [:pdahiya]]

Attachment: Screenshot Import Screen on Windows (with patch)

NI Aaron to review screenshot fixing slight overlap on windows. Thanks

Comment 4

[Punam Dahiya [:pdahiya]]

Attachment: All Screens using zap on windows and mac

Comment 5

[Aaron Benson]

Looks great!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf1d5f8236f7
Fix zap overlap on import screen in windows r=Mardak

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/cf1d5f8236f7

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:pdahiya, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 9

[Punam Dahiya [:pdahiya]]

(In reply to Release mgmt bot [:sylvestre / :calixte / :marco for bugbug] from comment #8)

The patch landed in nightly and beta is affected.
:pdahiya, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

yes we would like to uplift this fix to beta, submitting beta uplift request now

Comment 10

[Punam Dahiya [:pdahiya]]

Comment on attachment 9162291 [details]
Bug 1649407 - Fix zap overlap on import screen in windows

Beta/Release Uplift Approval Request

• User impact if declined: UI facing fix seen by windows user enrolled in planned v2 experiment in 79
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: https://bugzilla.mozilla.org/show_bug.cgi?id=1649407#c0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Low risk one line css fix
• String changes made/needed: None

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9162291 [details]
Bug 1649407 - Fix zap overlap on import screen in windows

Approved for 79.0b8.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1d3c673f4010

Comment 13

[Robert Martin [:romartin], Ecosystem QA]

I have verified that the zap image no longer covers the "welcome-text" on the "Import" slide of the "about:welcome" page by following the steps provided in the description, using Firefox Nightly 80.0a1 (Build ID: 20200714083249), and Firefox Beta 79.0b8 (Build ID: 2020071421200) on Windows 10 x64.