Pause/Resume context menu options are no longer displayed in downloads panel
Categories
(Firefox :: Downloads Panel, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox-esr78 | --- | unaffected |
firefox77 | --- | unaffected |
firefox78 | --- | unaffected |
firefox79 | + | verified |
firefox80 | + | verified |
People
(Reporter: atrif, Assigned: sfoster)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
Affected versions
- 79.0b1 (20200629224419)
- 80.0a1 (20200629154604)
Affected platforms
- Windows 10x64
- Ubuntu 18.04
- macOS 10.15
Steps to reproduce
- Open Firefox and performed a random download (e.g)
- Open download panel and search for Pause/Resume context menu options.
Expected result
- Pause/Resume context menu options are displayed.
Actual result
- Pause/Resume context menu options are no longer displayed.
Regression range
Last good revision: ee812b6359befd98993f39f8cffd6735ebcd5644 (2020-06-25)
First bad revision: 9b981fcfb6ac3119837605e3189c5832446c77ab (2020-06-26)
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ee812b6359befd98993f39f8cffd6735ebcd5644&tochange=9b981fcfb6ac3119837605e3189c5832446c77ab
Possible regressor: bug 1639069
Severity: S3
Reporter | ||
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
I'm on it. Looks like maybe an uncaught exception handling unknown mime-typed downloads
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 2•4 years ago
|
||
Comment 4•4 years ago
|
||
bugherder |
Reporter | ||
Comment 5•4 years ago
|
||
Verified the issue using Firefox 80.0a1 (20200702094606) on Windows 10x64, macOS 10.12 and Ubuntu 18.04. Pause/Resume
context menu options are shown in the download manager.
Assignee | ||
Comment 6•4 years ago
|
||
Comment on attachment 9160495 [details]
Bug 1649421 - Handle null mimeInfo from a download when populating the context menu. r?Jaws
Beta/Release Uplift Approval Request
- User impact if declined: Some of the context menu items for in-progress downloads will be missing, including the ability to pause/resume downloads.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce: Manual STR are in the bug in comment 0, but this is also covered by automated tests now.
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): The issue was tracked down to an un-caught exeception in context-menu-specific downloads code added by bug 1639069. This patch fixes all occurances and makes no other functional changes. Its well isolated and well tested - new browser-chrome tests confirm the fix (and fail when the functional changes are reverted)
- String changes made/needed: None
Comment 7•4 years ago
|
||
Comment on attachment 9160495 [details]
Bug 1649421 - Handle null mimeInfo from a download when populating the context menu. r?Jaws
Approved for 79.0b3. Thanks for including new tests.
Comment 8•4 years ago
|
||
bugherder uplift |
Updated•4 years ago
|
Comment 9•4 years ago
|
||
I verified the fix using Firefox 79.0b3 using Windows 10x64, macOS 10.13 and Ubuntu 18.04 x64. The issue is not reproducing anymore.
Updated•4 years ago
|
Description
•