Closed Bug 1649421 Opened 4 years ago Closed 4 years ago

Pause/Resume context menu options are no longer displayed in downloads panel

Categories

(Firefox :: Downloads Panel, defect)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
Firefox 80
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox77 --- unaffected
firefox78 --- unaffected
firefox79 + verified
firefox80 + verified

People

(Reporter: atrif, Assigned: sfoster)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Affected versions

  • 79.0b1 (20200629224419)
  • 80.0a1 (20200629154604)

Affected platforms

  • Windows 10x64
  • Ubuntu 18.04
  • macOS 10.15

Steps to reproduce

  1. Open Firefox and performed a random download (e.g)
  2. Open download panel and search for Pause/Resume context menu options.

Expected result

  • Pause/Resume context menu options are displayed.

Actual result

  • Pause/Resume context menu options are no longer displayed.

Regression range
Last good revision: ee812b6359befd98993f39f8cffd6735ebcd5644 (2020-06-25)
First bad revision: 9b981fcfb6ac3119837605e3189c5832446c77ab (2020-06-26)
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ee812b6359befd98993f39f8cffd6735ebcd5644&tochange=9b981fcfb6ac3119837605e3189c5832446c77ab
Possible regressor: bug 1639069

Severity: S3

Has Regression Range: --- → yes
Has STR: --- → yes

I'm on it. Looks like maybe an uncaught exception handling unknown mime-typed downloads

Flags: needinfo?(sfoster)
Assignee: nobody → sfoster
Status: NEW → ASSIGNED
Pushed by sfoster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3d74cf6d90cb Handle null mimeInfo from a download when populating the context menu. r=jaws
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 80

Verified the issue using Firefox 80.0a1 (20200702094606) on Windows 10x64, macOS 10.12 and Ubuntu 18.04. Pause/Resume context menu options are shown in the download manager.

Comment on attachment 9160495 [details]
Bug 1649421 - Handle null mimeInfo from a download when populating the context menu. r?Jaws

Beta/Release Uplift Approval Request

  • User impact if declined: Some of the context menu items for in-progress downloads will be missing, including the ability to pause/resume downloads.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce: Manual STR are in the bug in comment 0, but this is also covered by automated tests now.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The issue was tracked down to an un-caught exeception in context-menu-specific downloads code added by bug 1639069. This patch fixes all occurances and makes no other functional changes. Its well isolated and well tested - new browser-chrome tests confirm the fix (and fail when the functional changes are reverted)
  • String changes made/needed: None
Attachment #9160495 - Flags: approval-mozilla-beta?

Comment on attachment 9160495 [details]
Bug 1649421 - Handle null mimeInfo from a download when populating the context menu. r?Jaws

Approved for 79.0b3. Thanks for including new tests.

Attachment #9160495 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]
Flags: qe-verify+

I verified the fix using Firefox 79.0b3 using Windows 10x64, macOS 10.13 and Ubuntu 18.04 x64. The issue is not reproducing anymore.

Status: RESOLVED → VERIFIED
Regressed by: 1639069
QA Whiteboard: [qa-triaged]
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: