Closed Bug 1649529 Opened 1 month ago Closed 1 month ago

Deprecate GeckoSession (de)serializability to Parcel

Categories

(GeckoView :: General, task, P1)

Unspecified
All

Tracking

(firefox79 fixed, firefox80 fixed)

RESOLVED FIXED
mozilla80
Tracking Status
firefox79 --- fixed
firefox80 --- fixed

People

(Reporter: aklotz, Assigned: aklotz)

References

(Blocks 1 open bug)

Details

(Whiteboard: [geckoview:m80])

Attachments

(1 file)

This causes a lot of problems and does not match the expected semantics of Parcelable, for example, it is not possible to transfer a serialized GeckoSession across processes.

Note: These comments reference GeckoView 82 instead of GeckoView 83 because I
plan to uplift this to GeckoView 79. Ditto for the changelog entry.

Tests that use the parcelable functionality are flagged to ignore deprecation
warnings.

Blocks: 1650108
Pushed by aklotz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/624547a0b29c
Deprecate GeckoSession parcelability; r=geckoview-reviewers,agi

Comment on attachment 9160497 [details]
Bug 1649529: Deprecate GeckoSession parcelability; r=#geckoview-reviewers

Beta/Release Uplift Approval Request

  • User impact if declined: None, however it would postpone GeckoView API removals by one release cycle.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This patch just adds deprecation annotations to APIs that we plan to remove in a future GeckoView release.
  • String changes made/needed:
Attachment #9160497 - Flags: approval-mozilla-beta?
Flags: needinfo?(aklotz)
Pushed by aklotz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ff4059e08ee0
Deprecate GeckoSession parcelability; r=geckoview-reviewers,agi
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80

Comment on attachment 9160497 [details]
Bug 1649529: Deprecate GeckoSession parcelability; r=#geckoview-reviewers

approved for 79.0b4

Attachment #9160497 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.