1649529 - Deprecate GeckoSession (de)serializability to Parcel

Status: RESOLVED FIXED

(GeckoView :: General, task, P1)

Description

[(No longer employed by Mozilla) Aaron Klotz]

This causes a lot of problems and does not match the expected semantics of Parcelable, for example, it is not possible to transfer a serialized GeckoSession across processes.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1649529: Deprecate GeckoSession parcelability; r=#geckoview-reviewers

Note: These comments reference GeckoView 82 instead of GeckoView 83 because I
plan to uplift this to GeckoView 79. Ditto for the changelog entry.

Tests that use the parcelable functionality are flagged to ignore deprecation
warnings.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/624547a0b29c
Deprecate GeckoSession parcelability; r=geckoview-reviewers,agi

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 9160497 [details]
Bug 1649529: Deprecate GeckoSession parcelability; r=#geckoview-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: None, however it would postpone GeckoView API removals by one release cycle.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch just adds deprecation annotations to APIs that we plan to remove in a future GeckoView release.
• String changes made/needed:

Comment 4

[Natalia Csoregi [:nataliaCs]]

Backed out for linting failure on GeckoSession.java

backout: https://hg.mozilla.org/integration/autoland/rev/1d644f47dad6b4177bd85475b02c549db8bd8570

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=EL7LYVuETp-dndaV4bwYkQ.0&revision=624547a0b29caa05bcd10bdfd938d95a74aa15f8&searchStr=linting%2Copt%2Candroid%2Cgradle%2Ctests%2Csource-test-mozlint-android-lints%2Ca%28lints%29

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=308330454&repo=autoland&lineNumber=1452

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff4059e08ee0
Deprecate GeckoSession parcelability; r=geckoview-reviewers,agi

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/ff4059e08ee0

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 9160497 [details]
Bug 1649529: Deprecate GeckoSession parcelability; r=#geckoview-reviewers

approved for 79.0b4

Comment 8

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8314c4d75b90