Closed Bug 1649548 Opened 11 months ago Closed 11 months ago

Up/down key presses in filter autocomplete are propagated to filter input

Categories

(DevTools :: Netmonitor, defect, P3)

Product:
DevTools
Component:
Netmonitor
Version:
77 Branch
Platform:
Desktop
All
Type:
defect

Tracking

(firefox80 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 80
Tracking Flags:
Tracking Status
firefox80 --- fixed

People

(Reporter: real.trd, Assigned: real.trd)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(2 files)

Screen Recording 2020-06-29 at 19.07.01.mov
488.20 KB, video/quicktime
Details
Bug 1649548 - Autocomplete list events are not propagated to input. r=Honza
47 bytes, text/x-phabricator-request
Details | Review

Steps to reproduce

  1. Open DevTools Network Monitor
  2. Focus on Filter input
  3. Type some text and invoke autocomplete display
  4. Press up, down keys to navigate next/prev items in autocomplete list

What happened?

Besides list navigation, up key press moves filter's input cursor to begin, down key press moves filter's input cursor to end.
Check attached video for details

What should have happened?

up/down keys must not effect to input cursor position

Probably here should be preventDefault call

Hi Stanislav,

Thanks for the report.
I can reproduce the issue and the suggested fix is correct.

Cheers

Blocks: request-filtering
Severity: -- → S3
Keywords: good-first-bug
Priority: -- → P3

(In reply to Stanislav Goncharov from comment #1)

Probably here should be preventDefault call

Adding a permalink for the location to fix mentioned in comment above. See here

Stanislav,
Would you be interested in fixing the bug?

Flags: needinfo?(real.trd)

Yep, I can handle it

Flags: needinfo?(real.trd)

Excellent . Assigned to you.
If you any question let me know.
Thanks.

Assignee: nobody → real.trd
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5cbcce6ef3e5
Autocomplete list events are not propagated to input. r=Honza

It seems that on Linux and Windows platforms same issue affects Home/End (both Linux and Windows) and PageUp/PageDown (Linux only) events.
I have updated patch

Flags: needinfo?(real.trd)
Pushed by abutkovits@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/8a70ef88e4aa
Autocomplete list events are not propagated to input. r=Honza

https://hg.mozilla.org/mozilla-central/rev/8a70ef88e4aa

Status: ASSIGNED → RESOLVED
Closed: 11 months ago
status-firefox80: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 80
You need to log in before you can comment on or make changes to this bug.