1649548 - Up/down key presses in filter autocomplete are propagated to filter input

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[Stanislav Goncharov [:thegoncharov]]

Attachment: Screen Recording 2020-06-29 at 19.07.01.mov

Steps to reproduce

1. Open DevTools Network Monitor
2. Focus on Filter input
3. Type some text and invoke autocomplete display
4. Press up, down keys to navigate next/prev items in autocomplete list

What happened?

Besides list navigation, up key press moves filter's input cursor to begin, down key press moves filter's input cursor to end.
Check attached video for details

What should have happened?

up/down keys must not effect to input cursor position

Comment 1

[Stanislav Goncharov [:thegoncharov]]

Probably here should be preventDefault call

Comment 2

[Hubert Boma Manilla (:bomsy)]

Hi Stanislav,

Thanks for the report.
I can reproduce the issue and the suggested fix is correct.

Cheers

Comment 3

[Hubert Boma Manilla (:bomsy)]

(In reply to Stanislav Goncharov from comment #1)

Probably here should be preventDefault call

Adding a permalink for the location to fix mentioned in comment above. See here

Comment 4

[Hubert Boma Manilla (:bomsy)]

Stanislav,
Would you be interested in fixing the bug?

Comment 5

[Stanislav Goncharov [:thegoncharov]]

Yep, I can handle it

Comment 6

[Hubert Boma Manilla (:bomsy)]

Excellent . Assigned to you.
If you any question let me know.
Thanks.

Comment 7

[Stanislav Goncharov [:thegoncharov]]

Attachment: Bug 1649548 - Autocomplete list events are not propagated to input. r=Honza

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5cbcce6ef3e5
Autocomplete list events are not propagated to input. r=Honza

Comment 9

[Dorel Luca [:dluca]]

Backed out changeset 5cbcce6ef3e5 (bug 1649548) for Mochitest failures in components/test/chrome/test_searchbox-with-autocomplete.html. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=308693156&repo=autoland&lineNumber=1951

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=5cbcce6ef3e589ae6827de700c739e4afe050096

Backout:
https://hg.mozilla.org/integration/autoland/rev/3ba0ecffe7b3e26fdc12f3ee080cdddf77249621

Comment 10

[Stanislav Goncharov [:thegoncharov]]

It seems that on Linux and Windows platforms same issue affects Home/End (both Linux and Windows) and PageUp/PageDown (Linux only) events.
I have updated patch

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/8a70ef88e4aa
Autocomplete list events are not propagated to input. r=Honza

Comment 12

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/8a70ef88e4aa