1649558 - Turn off search modernisation for 78 release

Status: VERIFIED FIXED

(Firefox :: Search, defect, P1)

Description

[Mark Banner (:standard8)]

Due to issues found during release (bug 1649393), we've decided to turn off modernisation for the 78 release.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1649558 - Turn off search modernisation for 78 release. r?daleharvey!

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 9160462 [details]
Bug 1649558 - Turn off search modernisation for 78 release. r?daleharvey!

Beta/Release Uplift Approval Request

• User impact if declined: Possible issues with not being able to run Firefox properly due to search failing to initialise (bug 1649393).
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: QA should verify that legacy is properly enabled and still works correctly.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Should be reverting to the previous code by pref change.
• String changes made/needed: None

Comment 3

[Julien Cristau [:jcristau]]

Comment on attachment 9160462 [details]
Bug 1649558 - Turn off search modernisation for 78 release. r?daleharvey!

approved for 78.0.1

Comment 4

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-release/rev/31d99efb370c

Comment 5

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-esr78/rev/b508eed0c41a60b3993f96f400c41bbb8d81c041 (FIREFOX_ESR_78_0_X_RELBRANCH)

Search modernization remains enabled on the esr78 default branch (to-be 78.1.0esr).

Comment 6

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

We can confirm the feature is turned off, we verified using Windows 7 x64, Windows 10 x64, macOS 10.13 and Ubuntu 18.04.
In addition we ran some exploratory testing with focus in the following areas:

• trying to connect the staging server and alter the search engines;
• downgrades from the pre-dedicated profiles versions then upgrading to the latest;
• upgrades from 77;
• altering the search orders and adding other search engines;
• adding keywords to the search engines.

Comment 7

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

We also verified Fx 78.0.1esr following the steps and environments from the previous comment.