1649573 - run IPDL ipdl tests in parallel

Status: RESOLVED WONTFIX

(Firefox Build System :: General, enhancement)

Description

[Nathan Froyd [:froydnj]]

We are not implementing bug 1413205 for the reasons detailed in bug 1413205 comment 2. We can, however, make things faster with a bit of make hackery.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: Bug 1649573 - run IPDL ipdl tests in parallel; r=#build

The speedup here is not great because the Python/IPDL parser overhead is
very high, but this cuts ~10 seconds off a -j12 build (~15s -> 4s) on
my machine.

Comment 2

[Mike Hommey [:glandium]]

.... except they should actually not run in make check at all.

Comment 3

[Nathan Froyd [:froydnj]]

(In reply to Mike Hommey [:glandium] from comment #2)

.... except they should actually not run in make check at all.

Is this referring to the mythical separate make check task, or something else?

Comment 4

[Mike Hommey [:glandium]]

I guess that would be the mbu tasks.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3229e30f7721
run IPDL ipdl tests in parallel; r=firefox-build-system-reviewers,rstewart

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/3229e30f7721

Comment 7

[Mike Hommey [:glandium]]

Ironically, this had the opposite effect as the expected one: make check was about 107s before, and is now 126s. See https://treeherder.mozilla.org/perf.html#/graphs?series=autoland,2113344,1,2&selected=2113344,1176723737

Comment 8

[Nathan Froyd [:froydnj]]

(In reply to Mike Hommey [:glandium] from comment #7)

Ironically, this had the opposite effect as the expected one: make check was about 107s before, and is now 126s. See https://treeherder.mozilla.org/perf.html#/graphs?series=autoland,2113344,1,2&selected=2113344,1176723737

I don't understand this, but I'm going to chalk it up to make being terrible; I'll request a backout.

Comment 9

[Cosmin Sabou [:CosminS]]

Backed out on autoland, will later be merged to central: https://hg.mozilla.org/integration/autoland/rev/101279e0b8fbd2fdc2d17f7015b831d05c7744e0

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/101279e0b8fb

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:froydnj, could you have a look please?
For more information, please visit auto_nag documentation.