1649617 - ClientID.jsm imports OS.File during startup

Status: RESOLVED FIXED

(Toolkit :: OS.File, task)

Description

[Barret Rennie [:barret] (they/them)]

According to this startup profile, ClientID.jsm runs during startup and imports osfile.jsm. We should migrate this to the new IOUtils replacement for osfile.jsm when possible.

Stack:

(root) []
XREMain::XRE_main []
XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) [libxul.so]
XREMain::XRE_mainRun() [libxul.so]
nsAppStartup::Run() [libxul.so]
nsBaseAppShell::Run() [libxul.so]
MessageLoop::Run() [libxul.so]
mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) [libxul.so]
nsThread::ProcessNextEvent(bool, bool*) [libxul.so]
mozilla::CycleCollectedJSContext::AfterProcessTask(unsigned int) [libxul.so]
promise callback []
mozilla::PromiseJobRunnable::Run(mozilla::AutoSlowOperation&) [libxul.so]
mozilla::dom::PromiseJobCallback::Call(mozilla::dom::BindingCallContext&, JS::Handle<JS::Value>, mozilla::ErrorResult&) [libxul.so]
JS::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>) [libxul.so]
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
PromiseReactionJob(JSContext*, unsigned int, JS::Value*) [libxul.so]
AsyncFunctionResume(JSContext*, JS::Handle<js::AsyncFunctionGeneratorObject*>, ResumeKind, JS::Handle<JS::Value>) [libxul.so]
js::CallSelfHostedFunction(JSContext*, JS::Handle<js::PropertyName*>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>) [libxul.so]
js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) [libxul.so]
js::RunScript []
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
AsyncFunctionNext [self-hosted:688:26]
0xff4eaa5ea9f []
js::jit::InterpretResume(JSContext*, JS::Handle<JSObject*>, JS::Value*, JS::MutableHandle<JS::Value>) [libxul.so]
js::CallSelfHostedFunction(JSContext*, JS::Handle<js::PropertyName*>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>) [libxul.so]
js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) [libxul.so]
js::RunScript []
InterpretGeneratorResume [self-hosted:1146:33]
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
Interpret(JSContext*, js::RunState&) [libxul.so]
js::NativeGetExistingProperty(JSContext*, JS::Handle<JSObject*>, JS::Handle<js::NativeObject*>, JS::Handle<js::Shape*>, JS::MutableHandle<JS::Value>) [libxul.so]
js::CallGetter(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::MutableHandle<JS::Value>) [libxul.so]
js::RunScript []
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
get [resource://gre/modules/XPCOMUtils.jsm:124:20]
0xff4eaa5dbc7 []
js::jit::DoCallFallback(JSContext*, js::jit::BaselineFrame*, js::jit::ICCall_Fallback*, unsigned int, JS::Value*, JS::MutableHandle<JS::Value>) [libxul.so]
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
js::fun_apply(JSContext*, unsigned int, JS::Value*) [libxul.so]
js::fun_call(JSContext*, unsigned int, JS::Value*) [libxul.so]
js::RunScript []
> (root scope) resource://gre/modules/ClientID.jsm [resource://gre/modules/ClientID.jsm:42:52]
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
Interpret(JSContext*, js::RunState&) [libxul.so]
js::NativeGetExistingProperty(JSContext*, JS::Handle<JSObject*>, JS::Handle<js::NativeObject*>, JS::Handle<js::Shape*>, JS::MutableHandle<JS::Value>) [libxul.so]
js::CallGetter(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::MutableHandle<JS::Value>) [libxul.so]
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
mozilla::dom::module_getter::ModuleGetter(JSContext*, unsigned int, JS::Value*) [libxul.so]
mozJSComponentLoader::Import(JSContext*, nsTSubstring<char> const&, JS::MutableHandle<JSObject*>, JS::MutableHandle<JSObject*>, bool) [libxul.so]
profiler_get_backtrace() [libxul.so]
Registers::SyncPopulate() [libxul.so]

Comment 1

[Emma Malysz]

We should switch to using IOUtils equivalents here: https://searchfox.org/mozilla-central/rev/d25eb00ab4e90cc0130cd18f303a04cc2a2f8409/toolkit/components/telemetry/app/ClientID.jsm#252,389

Comment 2

[Emma Malysz]

Attachment: Bug 1649617, remove OS.File usages from ClientID.jsm

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8000c25ea07c
remove OS.File usages from ClientID.jsm r=Gijs

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80032490e0aa
Backed out changeset 8000c25ea07c for xpcshell failures on ClientID.jsm. CLOSED TREE

Comment 5

[Cosmin Sabou [:CosminS]]

Backed out for xpcshell failures on ClientID.jsm

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&fromchange=8000c25ea07c00e94e9ab468e59091e455eea2a9&searchStr=xpc&selectedTaskRun=KBAgROHmTRq7jSIrbZvwNg.0&tochange=80032490e0aa5916687897af6255be38d494821a

Failure log: https://treeherder.mozilla.org/logviewer?job_id=321639093&repo=autoland
https://treeherder.mozilla.org/logviewer?job_id=321637864&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/80032490e0aa5916687897af6255be38d494821a

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/044d17174437
remove OS.File usages from ClientID.jsm r=Gijs

Comment 7

[Narcis Beleuzu [:NarcisB]]

Backed out for xpcshell failure on test_TelemetrySend.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/bea06b87f022222b03d66df9e55062085fd11542
Log link: https://treeherder.mozilla.org/logviewer?job_id=322333071&repo=autoland&lineNumber=2867

Comment 8

[Release mgmt bot [:sylvestre / :calixte / :marco for bugbug]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:emalysz, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 9

[Emma Malysz]

In test_telemetry.send.js, I see an error (A promise chain failed to handle a rejection: Shutting down and refusing additional I/O tasks - stack: _saveClientIDs@resource://gre/modules/ClientID.jsm:272:19), which I believe should be fixed once we fix Bug 1672431

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83b683b434b5
remove OS.File usages from ClientID.jsm r=Gijs

Comment 11

[Alexandru Michis [:malexandru]]

Backed out changeset 83b683b434b5 (Bug 1649617) for causing xpcshell failures in test_TelemetryController.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/785d03cbdab913871b428a7a29042a1c7cc2d064

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&tochange=785d03cbdab913871b428a7a29042a1c7cc2d064&fromchange=88aa4f503e22f1bb5ae1cb5529a9ddedd8dff61a&searchStr=xpcshell&selectedTaskRun=bmKbnuPgQiG_gsy0sr1a0A.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=326249075&repo=autoland&lineNumber=3800

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/268ce91cf117
remove OS.File usages from ClientID.jsm r=Gijs

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/268ce91cf117