1649653 - TestBaseProfiler.cpp should not compile SleepMilli() either without MOZ_GECKO_PROFILER

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect, P3)

Description

[Cameron Kaiser [:spectre]]

I suspect the fix for bug 1637895 is incomplete, because compiling the test binary now fails saying printf() is undefined. The #ifdef needs to be moved up a little higher in the file. Patch coming up.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Thank you for the report and upcoming patch 😀

Comment 2

[Cameron Kaiser [:spectre]]

Attachment: Bug 1649653 - fix compilation on non-profiler platforms. r?gerald

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4647ddd16fbd
fix compilation on non-profiler platforms. r=gerald

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/4647ddd16fbd

Comment 5

[Cameron Kaiser [:spectre]]

Comment on attachment 9160557 [details]
Bug 1649653 - fix compilation on non-profiler platforms. r?gerald

Beta/Release Uplift Approval Request

• User impact if declined: Builds off mozilla-release and -beta will be broken on Tier 3 platforms that do not support the Profiler.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Makes a single change to not compile a function on Tier 3 non-Profiler platforms that is otherwise NPOTB.
• String changes made/needed: None.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Breaks certain Tier 3 builds which usually rely on ESR for stability.
• User impact if declined: Builds off mozilla-release and -beta will be broken on Tier 3 platforms that do not support the Profiler.
• Fix Landed on Version: 80
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Makes a single change to not compile a function on Tier 3 non-Profiler platforms that is otherwise NPOTB.
• String or UUID changes made by this patch: None.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9160557 [details]
Bug 1649653 - fix compilation on non-profiler platforms. r?gerald

Compilation fix for Tier 3 platforms. NPOTB for platforms we ship. Approved for 79.0b3, 78.1esr, and 78.0.2.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/002beecf7a10859d138d17ef7e436f90f9632c0b
https://hg.mozilla.org/releases/mozilla-release/rev/da90f1a68a9bd57f98228aa653edd6335a62bc1b
https://hg.mozilla.org/releases/mozilla-esr78/rev/7a5191c1f123e950ea968f52f82b5c3343a7ab76 (default)
https://hg.mozilla.org/releases/mozilla-esr78/rev/1bd79f7d9143c8e7c8144f2931ffc36f45dc4417 (FIREFOX_ESR_78_0_X_RELBRANCH)