1649655 - [MIPS] Fix build issues caused by recent change (visitWasmRegisterResult)

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Zhao Jiazhong]

Failed to build js on mips machine due to some changes in D80820:

js/src/jit/CodeGenerator.cpp:6800: undefined reference to 'js::jit::CodeGenerator::visitWasmRegisterResult(js::jit::LWasmRegisterResult*)'

Comment 1

[Zhao Jiazhong]

The change's bug id is 1646787, and it may be security-related, I don't have the access to the bug and revision.
According to the code, the bug seems only affect x64 platform, so I will just add an empty visitWasmRegisterResult function to mips platform just like arm and x86.

Comment 2

[Zhao Jiazhong]

Attachment: Bug 1649655 - [MIPS] Add CodeGenerator::visitWasmRegisterResult function. r=lth

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a82ed51397f1
[MIPS] Add CodeGenerator::visitWasmRegisterResult function. r=lth

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/a82ed51397f1

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 9160558 [details]
Bug 1649655 - [MIPS] Add CodeGenerator::visitWasmRegisterResult function. r=lth

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Build failure on MIPS following bug 1646787.
• User impact if declined:
• Fix Landed on Version: 80
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): NPOTB
• String or UUID changes made by this patch:

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9160558 [details]
Bug 1649655 - [MIPS] Add CodeGenerator::visitWasmRegisterResult function. r=lth

Approved for 78.4esr.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr78/rev/baf8a8d379dc100599e1a5bbe15fe53b09164d35