1649676 - Disabling an @font-face font in macOS that’s used in a webpage crashes Firefox

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Robin Whittleton]

Attachment: font-face-crash-testcase.html

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:80.0) Gecko/20100101 Firefox/80.0

Steps to reproduce:

1. Load reduced testcase in Firefox on macOS
2. Open FontBook app
3. Right click on Zapfino and disable it

Actual results:

Firefox crash. See for example https://crash-stats.mozilla.org/report/index/fb010147-10d7-4133-b174-eac420200701

Expected results:

No crash, and the testcase should revert to the system default font. When Zapfino is directly specified without using an @font-face rule this is the case and there’s no crash.

Comment 1

[BugBot [:suhaib / :marco]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Jonathan Kew [:jfkthame]]

Doesn't seem to crash for me with webrender disabled; moving to WR component.

Comment 3

[Jonathan Kew [:jfkthame]]

And with WR enabled, it does reproduce (note that it crashes the whole browser, not just the tab).

Comment 4

[Robin Whittleton]

Oh, sorry, I thought I tested it in both modes otherwise I would have put a WR label on it, must have not restarted the browser or something. And yes, it’s whole-browser crash, not tab.

Comment 5

[Bert Peers [:bpeers]]

Reproduces on Mac on central cc7eafcda.

Comment 6

[Lee Salzman [:lsalzman]]

Attachment: Bug 1649676 - use fallback font if loading WR mac font descriptor fails. r?jfkthame

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f25c770ccbf3
use fallback font if loading WR mac font descriptor fails. r=jfkthame

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/f25c770ccbf3

Comment 9

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Successfully reproduced the issue on Firefox Nightly (2020-06-30) under macOS 10.15.6 by following the STR from Comment 0.

The issue is fixed on Firefox 80.0b7 (webrender manually activated) and on Firefox Nightly 81.0a1 (2020-08-13).