1649720 - Preferences: XUL:tree and related are improperly exposed to VoiceOver, appear empty or broken.

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[Marco Zehe (:MarcoZ)]

This pertains, among others, to the Security Device Manager.

1. With VoiceOver on, open about:preferences.
2. Navigate to the Privacy category.
3. At the bottom, click Security Devices.
4. Try to navigate the tables and other controls in the dialog that appears.
   • Result: VoiceOver only ever sees one table, and it is always empty.
   • Tabbing may focus other elements that are somehow created, but disconnected from VoiceOver's view otherwise.

All in all, these dialogs are not workable with VoiceOver.

This is closely related to bug 1644810, but this is more about tree tables, or treegrid in ARIA terms.

This works fine on Windows.

Comment 1

[Marco Zehe (:MarcoZ)]

Another example is the list of one-off search engines in the Search category of Preferences, where we even have several checkable items in a table and column headers.

Comment 2

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1649720: Ensure XUL trees expose their internal columns to VoiceOver r?eeejay!

Depends on D96960

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a7e15d51a4c
Ensure XUL trees expose their internal columns to VoiceOver r=eeejay

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/8a7e15d51a4c

Comment 5

[Razvan Maries]

Backed out for perma failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=mozilla-central&group_state=expanded&selectedTaskRun=P2ShmbY-T1qjPGEnq_cFYA.0&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=os%2Cx%2C10.14%2Cwebrender%2Cdebug%2Cmochitests%2Ctest-macosx1014-64-qr%2Fdebug-mochitest-browser-chrome-e10s%2Cbc4

Log: https://treeherder.mozilla.org/logviewer?job_id=323982803&repo=mozilla-central&lineNumber=3495

Backout: https://hg.mozilla.org/integration/autoland/rev/b4cd29abb74ae321be6176130fcd2130c7179d6d

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/b4cd29abb74a

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71a611cf5fb9
Ensure XUL trees expose their internal columns to VoiceOver r=eeejay

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/71a611cf5fb9

Comment 9

[Catalin Sasca, Desktop QA [:csasca]]

Tried reproducing on affected build, but I was unable to do so on macOS 10.15.7 and 11.1 respectively.

Spoke with Marco about this and said that this is fixed for him, so it is safe to mark it as verified.