1649723 - Pushlog query with cloned fromchangeset errors

Status: RESOLVED FIXED

(Developer Services :: Mercurial: Pushlog, defect)

Description

[Axel Hecht [:Pike]]

When querying the pushlog for pushes newer than a revision, there's a 500 error if that changeset was never pushed. I.e., if it was cloned.

Example URL would be https://hg.mozilla.org/releases/comm-esr78/json-pushes?tipsonly=1&tochange=default&fromchange=548b029d0a156dca9ef3954b8ec489b40484bb2f.

We're hitting that bug while adding ESR 78 to the l10n cross-channel setup, bug 1649420

Comment 1

[Axel Hecht [:Pike]]

Attachment: pushlog: Start pushlog at 0 if fromchange is a cloned revision (Bug 1649723) r=sheehan

Comment 2

[Axel Hecht [:Pike]]

Looking at the error, it's so generic that I'm concerned to add workarounds. It'd be "whenever you get a 500 error, pull the complete pushlog".

It feels easier to me to patch hgmo instead ;-)

Thus, marking this as blocking bug 1649420.

I got to the point where I can run tests locally, but hgext/pushlog/tests/test-user.t doesn't pass for me locally on the test-runner image.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/19a77a5d7b2a
pushlog: Start pushlog at 0 if fromchange is a cloned revision r=sheehan

Comment 4

[Francesco Lodolo [:flod]]

Any chance to deploy this? My understanding is that deployment only happens on-demand, not on schedule.

We need this for bug 1649420, which needs to happen before 78 gets kicked out of mozilla-release.

Comment 5

[Connor Sheehan [:sheehan]]

(In reply to Francesco Lodolo [:flod] from comment #4)

Any chance to deploy this? My understanding is that deployment only happens on-demand, not on schedule.

We need this for bug 1649420, which needs to happen before 78 gets kicked out of mozilla-release.

Done!

Comment 6

[Axel Hecht [:Pike]]

Sweet, thanks, that worked.