1649753 - Check if EnvironmentFront is ever used

Status: RESOLVED FIXED

(DevTools :: Framework, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

As Julian mentionned in phabricator :

I am wondering if we are using the front at all?

1/ We never instantiate it https://searchfox.org/mozilla-central/search?path=&q=new%20EnvironmentFront (apart from the test you modified)
2/ In the specs it is only referenced as the return value of ObjectActor::scope, which I think is only called from ObjectFront::getScope, which is only used in one test: https://searchfox.org/mozilla-central/search?q=.getScope%28&case=true&path=devtools
3/ frame.getEnvironment expects a json answer, therefore protocol.js never creates an Environment front.

We should check if the EnvironmentFront is used, and if not, remove it.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1649753 - Remove unused EnvironmentFront. r=jdescottes.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7609cb96908
Remove unused EnvironmentFront. r=jdescottes,devtools-backward-compat-reviewers.

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/b7609cb96908