Closed Bug 1649755 Opened 4 years ago Closed 3 months ago

Re-enable browser_ContentSearch.js mochitest for content search

Categories

(Firefox :: Search, defect, P3)

defect

Tracking

()

RESOLVED FIXED
124 Branch
Tracking Status
firefox124 --- fixed

People

(Reporter: ssengupta, Assigned: standard8)

Details

Attachments

(1 file)

browser/modules/test/browser/browser_ContentSearch.js is to be disabled as a part of Bug 1619953 because it always causes shutdown leaks after changes that make the acquired stream asynchronous.

Shutdown leaks only happen on 64bit Linux with Fission not enabled.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1dc61c190b34031155341c958c0fd857d584f635

Since this is the only test to be suffering from such leaks, and that too only for a particular configuration, it is possible that the test requires examination.


EDIT: Leak also seems to happen with Fission enabled, but intermittently.
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=9f610c8c44de2797e1b32ca92eb6a6c83c884a6d&searchStr=browser-chrome&selectedTaskRun=XMkRcCyhS4yFl97Leat8UA.0

Flags: needinfo?(dharvey)

Not an obvious owner for this so will take a look at fixing

Assignee: nobody → dharvey
Flags: needinfo?(dharvey)

Deassigning until dep lands

Assignee: dharvey → nobody
Summary: Re-enable browser mochitest for content search → Re-enable browser_ContentSearch.js mochitest for content search

I ran this through try server and it appears we're not leaking any more. We do still see bug 1775793, but that's a separate issue. Hence I think we can re-enable this on Linux 64 debug.

Assignee: nobody → standard8
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/945fa6ab7a45
Re-enable browser_contentSearch.js on Linux 64 debug builds. r=search-reviewers,jteow
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 124 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: