1649813 - Test that browser.dns APIs don't work when the proxy should be handling DNS

Status: RESOLVED FIXED

(WebExtensions :: General, task, P1)

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1649813 test dns api failure when forwarding dns to socks proxy

Comment 2

[Shane Caraveo (:mixedpuppy)]

This should also be documented, that DNS will fail with NS_ERROR_UNKNOWN_PROXY_HOST if proxying DNS over socks is enabled.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/617c0511e0c8
test dns api failure when forwarding dns to socks proxy r=mayhemer,necko-reviewers

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset 617c0511e0c8 (bug 1649813) for test_ext_dns.js failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=linux%2C18.04%2Cx64%2Cdebug%2Cxpcshell%2Ctests%2Cwith%2Cnetworking%2Con%2Csocket%2Cprocess%2Ctest-linux1804-64%2Fdebug-xpcshell-spi-nw-e10s%2Cx5&fromchange=c4186bb32c302ec2c82b3b0323af828ccebe0b48&tochange=41d526a96b98d6df1b42da7a7281958a31c84c18&selectedTaskRun=bYOthWWuSNK_wmpov9o62Q.0

Backout link: https://hg.mozilla.org/integration/autoland/rev/41d526a96b98d6df1b42da7a7281958a31c84c18

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309889929&repo=autoland&lineNumber=1863

task 2020-07-15T19:54:06.170Z] 19:54:06     INFO -  TEST-START | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_dns.js
[task 2020-07-15T19:54:08.978Z] 19:54:08  WARNING -  TEST-UNEXPECTED-FAIL | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_dns.js | xpcshell return code: -11
[task 2020-07-15T19:54:08.978Z] 19:54:08     INFO -  TEST-INFO took 2814ms
...
...
...

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

The following seems to start with the backed out changes:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309893246&repo=autoland&lineNumber=1210

Comment 6

[Honza Bambas (:mayhemer)]

I'll take a look.

Comment 7

[Honza Bambas (:mayhemer)]

This needs to be disabled with socket-process on.

Comment 8

[Honza Bambas (:mayhemer)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5e624119728c6cbabe88fcdd706e1f02763e1baf

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d745eb8f40b3
test dns api failure when forwarding dns to socks proxy r=mayhemer,necko-reviewers

Comment 10

[Natalia Csoregi [:nataliaCs]]

Backed out for awsy proxy failures

backout: https://hg.mozilla.org/integration/autoland/rev/27b9d717a2014ef408dd3e4c7c6175deacf0c8e5

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=awsy-e10s%2Csy&revision=d745eb8f40b3c813657476ebc0001c8982db7a71&selectedTaskRun=CNg9ecr1SjusNJ_sSOLceg.0

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=310181392&repo=autoland&lineNumber=747

[task 2020-07-17T15:45:47.205Z] 15:45:47 INFO - starting checkpoint StartSettled...
[task 2020-07-17T15:45:47.707Z] 15:45:47 INFO - checkpoint created, stored in Z:\task_1595000412\build\tests\results\memory-report-StartSettled-0.json.gz
[task 2020-07-17T15:45:47.711Z] 15:45:47 INFO - loading http://localhost:8001/page_load_test/tp5n/thesartorialist.blogspot.com/thesartorialist.blogspot.com/index.html
[task 2020-07-17T15:45:48.067Z] 15:45:48 INFO - TEST-UNEXPECTED-ERROR | awsy/test_memory_usage.py TestMemoryUsage.test_open_tabs | UnknownException: Reached error page: about:neterror?e=proxyResolveFailure&u=http%3A//localhost%3A8001/page_load_test/tp5n/thesartorialist.blogspot.com/thesartorialist.blogspot.com/index.html&c=UTF-8&d=Firefox%20is%20configured%20to%20use%20a%20proxy%20server%20that%20can%E2%80%99t%20be%20found.
[task 2020-07-17T15:45:48.067Z] 15:45:48 INFO - stacktrace:
[task 2020-07-17T15:45:48.067Z] 15:45:48 INFO - WebDriverError@chrome://marionette/content/error.js:175:5
[task 2020-07-17T15:45:48.067Z] 15:45:48 INFO - UnknownError@chrome://marionette/content/error.js:482:5
[task 2020-07-17T15:45:48.068Z] 15:45:48 INFO - handleReadyState@chrome://marionette/content/listener.js:300:13
[task 2020-07-17T15:45:48.068Z] 15:45:48 INFO - handleEvent@chrome://marionette/content/listener.js:266:14
[task 2020-07-17T15:45:48.068Z] 15:45:48 INFO - Traceback (most recent call last):
[task 2020-07-17T15:45:48.068Z] 15:45:48 INFO - File "z:\task_1595000412\build\venv\lib\site-packages\marionette_harness\marionette_test\testcases.py", line 196, in run
[task 2020-07-17T15:45:48.068Z] 15:45:48 INFO - testMethod()
[task 2020-07-17T15:45:48.068Z] 15:45:48 INFO - File "Z:\task_1595000412\build\tests\awsy\awsy\test_memory_usage.py", line 211, in test_open_tabs
[task 2020-07-17T15:45:48.068Z] 15:45:48 INFO - self.open_pages()
[task 2020-07-17T15:45:48.068Z] 15:45:48 INFO - File "z:\task_1595000412\build\venv\lib\site-packages\awsy\awsy_test_case.py", line 404, in open_pages
[task 2020-07-17T15:45:48.068Z] 15:45:48 INFO - self.open_and_focus()
[task 2020-07-17T15:45:48.068Z] 15:45:48 INFO - File "z:\task_1595000412\build\venv\lib\site-packages\awsy\awsy_test_case.py", line 358, in open_and_focus
[task 2020-07-17T15:45:48.068Z] 15:45:48 INFO - self.marionette.navigate(page_to_load)
[task 2020-07-17T15:45:48.068Z] 15:45:48 INFO - File "z:\task_1595000412\build\venv\lib\site-packages\marionette_driver\marionette.py", line 1469, in navigate
[task 2020-07-17T15:45:48.068Z] 15:45:48 INFO - {"url": url})
[task 2020-07-17T15:45:48.068Z] 15:45:48 INFO - File "z:\task_1595000412\build\venv\lib\site-packages\marionette_driver\decorators.py", line 26, in _
[task 2020-07-17T15:45:48.069Z] 15:45:48 INFO - return func(*args, **kwargs)
[task 2020-07-17T15:45:48.069Z] 15:45:48 INFO - File "z:\task_1595000412\build\venv\lib\site-packages\marionette_driver\marionette.py", line 602, in _send_message
[task 2020-07-17T15:45:48.069Z] 15:45:48 INFO - self._handle_error(err)
[task 2020-07-17T15:45:48.069Z] 15:45:48 INFO - File "z:\task_1595000412\build\venv\lib\site-packages\marionette_driver\marionette.py", line 622, in _handle_error
[task 2020-07-17T15:45:48.069Z] 15:45:48 INFO - raise errors.lookup(error)(message, stacktrace=stacktrace)
[task 2020-07-17T15:45:48.069Z] 15:45:48 INFO - TEST-INFO took 31617ms

Comment 11

[Honza Bambas (:mayhemer)]

Interesting! So we have even more tests that are affected by this change. I'll look at it. Next time through full try even for something this trivial...

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6dea4da50bf5
test dns api failure when forwarding dns to socks proxy r=mayhemer,necko-reviewers,dragana

Comment 13

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/6dea4da50bf5

Comment 14

[Caitlin Neiman [:caitmuenster]]

Hey Shane, I'm picking up this dev-doc-needed.

Is this the correct page to update? https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/dns

From comment #1 it looks like we need to add the note, "DNS will fail with NS_ERROR_UNKNOWN_PROXY_HOST if proxying DNS over socks is enabled." Is that still correct?

Let me know if anything else is needed!

Comment 15

[Shane Caraveo (:mixedpuppy)]

(In reply to Caitlin Neiman [:caitmuenster] from comment #14)

Hey Shane, I'm picking up this dev-doc-needed.

Is this the correct page to update? https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/dns

From comment #1 it looks like we need to add the note, "DNS will fail with NS_ERROR_UNKNOWN_PROXY_HOST if proxying DNS over socks is enabled." Is that still correct?

Let me know if anything else is needed!

Yes, correct page and message.

Comment 16

[Caitlin Neiman [:caitmuenster]]

Done. Thanks! :)