1649865 - Can't scroll to the bottom of a bugzilla bug in Fenix

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Screenshot_20200701-080759_Firefox+Nightly.jpg

I was trying to comment on bug 1599160 in Fenix Nightly, and I couldn't get to the bottom buttons no matter what I did (desktop mode, rotate, reload, kill and restart, etc). I could get to them in other (shorter?) bugs.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

ni? kbrosnan to try with reference browser

Comment 3

[Botond Ballo [:botond]]

Bug 1650644 is similar (possibly a dupe, not sure yet) and there is some investigation ongoing there.

Comment 4

[Hiroyuki Ikezoe (:hiro)]

I wonder whether this is a recent regression or not.

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Randell, are you able to reproduce the issue on bugzilla pages where the content's width totally fits the screen width?

I was wondering why I can't see the issue on my environments (pixel 3 and an Android emulator), I noticed that in the screenshot in comment 0 there is a horizontal overflow area, so I guess the screenshot was taken after zooming in to some extent? (And I presume you couldn't zoom out to the original scale size due to bug 1652190)

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Loading this bug I can see the bottom buttons. If I select the Add Comment area, I can no longer see them even if I delete everything, dismiss the keyboard, etc. Killing the tab and reloading the URL restores the buttons.

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Thank you! That explains this is a dup of bug 1652190. When you click to the comment area, zoomToRect happens, which means the content is zoomed in to some extent.

Comment 8

[Kevin Brosnan [Ex-Mozilla]]

This does not seem to be fixed by bug 1652190. https://github.com/mozilla-mobile/fenix/issues/13055 and https://github.com/mozilla-mobile/fenix/issues/13198

Comment 9

[Botond Ballo [:botond]]

(In reply to Kevin Brosnan [:kbrosnan] from comment #8)

This does not seem to be fixed by bug 1652190. https://github.com/mozilla-mobile/fenix/issues/13055 and https://github.com/mozilla-mobile/fenix/issues/13198

I think there are multiple things going on in those Fenix issues:

• Not being able to interact with a button that was previously underneath the toolbar. I expect this was fixed recently by bug 1652288.
• Not being able to hide the toolbar in the first place, to reveal content underneath. The cause of this probably varies from page to page.
  • Bug 1650644 should fix some cases of this bug (in particular, cases where the page is not otherwise scrollable).
  • Bug 1633322 should fix other cases of this bug (in particular, cases that involve subframe scrolling or non-passive touch event listeners).
  • I am hopeful that between them, bug 1650644 and bug 1633322 fix all cases of this, but it's possible there are other issues we are overlooking.

Comment 11

[Hiroyuki Ikezoe (:hiro)]

I wonder whether bug 1663000 fixed this or not.

Comment 12

[Hiroyuki Ikezoe (:hiro)]

Randell, can you please check whether this issue still persists on Fenix nightly? I've confirmed bug 1663000 is included in the latest nightly.

Comment 13

[Randell Jesup [:jesup] (needinfo me)]

This does appear to be fixed. Thanks

Comment 14

[Hiroyuki Ikezoe (:hiro)]

Thank you!

Comment 15

[Chris Peterson [:cpeterson]]

Moving toolbar bugs to the new GeckoView::Toolbar component.