Closed
Bug 1649967
Opened 4 years ago
Closed 4 years ago
Add missing attributes for MOZ_[OWNING, NON_OWNING, UNSAFE]_REF
Categories
(Core :: MFBT, defect)
Core
MFBT
Tracking
()
RESOLVED
FIXED
mozilla80
| Tracking | Status | |
|---|---|---|
| firefox80 | --- | fixed |
People
(Reporter: jewilde, Assigned: jewilde)
Details
Attachments
(1 file)
While working on a static analysis check I noticed these weren't defined in the way we need and are missing the annotations for these macros. This would add annotation attributes back to MOZ_OWNING_REF, MOZ_NON_OWNING_REF, and MOZ_UNSAFE_REF when building with clang-plugin enabled.
|
Assignee | |
Comment 1•4 years ago
|
||
Pushed by rmaries@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a2088b1d758f Add missing annotation attributes to builds with clang-plugin enabled; r=froydnj
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox80:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
|
||
Comment 4•3 years ago
|
||
These annotations are not used in the tree as of now. I assume the work on the static analysis was not completed (yet)? Or was it implemented outside the tree. Can you link the bugs where this is needed for? (It actually would be very desirable if we had static analysis for these annotations!)
Flags: needinfo?(jewilde)
|
|
Assignee | |
Comment 5•3 years ago
|
||
The static analysis that these were needed for was implemented outside of tree
Flags: needinfo?(jewilde)
You need to log in
before you can comment on or make changes to this bug.
Description
•