1650033 - Diners Club logo is not detect when submit a credit card using a Diners Club CC number

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect, P2)

Description

[Alin Ilea, Desktop Test Engineering]

Attachment: Diners Club logo issue.png

Affected version:

All - if CC specific prefs are enabled.

Tested on:

Windows 10
Ubuntu 18.04

Steps to reproduce:

1. Submit a credit card (CC) form with a Diners Club card number e.g. 30569309025904 or 38520000023237.
2. Choose to save the Credit Card in the Save CC doorhanger.
3. Open the list of saved cards in preferences.

Expected results:

Diners Club logo is displayed beside the card.

Actual results:

No logo is displayed beside the card.

Note:

When submitting a Mastercard credit card, the Diners Club logo is displayed instead of Mastecard logo. The Diners Club logo displayed in the attached screenshot its actually a Mastercard saved credit card. (Bug 1649028)

Comment 1

[Adam Roach [:abr]]

Note -- the issue is that these cards are 14 digits long, while the card network detection code is expecting them to be 16.

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1650033 - Support length ranges in credit card IINs. r?abr

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

I verified against https://www.freeformatter.com/credit-card-number-generator-validator.html and extended the support to ranges as per Wikipedia plus a wider range for Diners.

I'm fairly okay with a wider net of types, since the card still has to match Luhn algorithm and in the worst case we're recognize a card of length that is not supported, but matches the prefix of IIN.

I also changed length property name to len because I find it confusing that range.length is a property of an object but also of a regular Array :) Hope it's ok!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2faa1e31dee0
Support length ranges in credit card IINs. r=abr

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/2faa1e31dee0

Comment 6

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed in latest Nightly 80.0a1 (build id: 20200711215253). Diners Club logo is displayed in the Saved Credit Cards after submitting a new Diners Club card.