1650045 - Remove references to whitelist/blacklist from SafeBrowsing

Status: RESOLVED FIXED

(GeckoView :: General, task, P3)

Description

[Dimi Lee [:dimi]]

Let's use a better naming

Comment 1

[Bruno Bartolomasi]

Attachment: Bug 1650045 - pt 1: Remove references to whitelist

Comment 2

[Bruno Bartolomasi]

Attachment: Bug 1650045 - pt 2: Remove references to blacklist

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:brunobrt, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 4

[Bruno Bartolomasi]

(In reply to Release mgmt bot [:sylvestre / :calixte / :marco for bugbug] from comment #3)

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:brunobrt, could you have a look, please?
For more information, please visit auto_nag documentation.

Both were accepted and were marked as "ready to land", so I thought my job was done. There were some comments on the patches though:

• pt 1: I was asked to undo the changes in exoplayer2 and leave it alone because it would make more sense to file an issue for Google, so I submitted again without those changes in exoplayer2, it was accepted.

• pt 2: It was accepted and, again, it was said that changes in exoplayer2 should be submitted to Google, but I wasn't asked to submit a new patch and undo those changes, so I didn't.

Since both patches were accepted and are ready to land I thought those suggestions to file an issue for Google could be done in a different issue and were only suggestions, not something that must be done in order to land. I'm not sure how to proceed.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:dimi, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 6

[Dimi Lee [:dimi]]

The patch seems to target on mobile related code, not SafeBrowsing.
agi, does this still something your team want? If yes, maybe you could move these patches to the right bug?

Comment 7

[Chris Peterson [:cpeterson]]

Good first bug. These patches are two years old, so they might not apply cleanly now.

Comment 8

[Nicholas Poon [:Nick]]

Attachment: Bug 1650045 - Rename references from whitelist/blacklist to allowlist/blocklist

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/afa3f2213f33
Rename references from whitelist/blacklist to allowlist/blocklist r=android-reviewers,calu

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/afa3f2213f33