1650066 - Fix View Source error reporting for template upon EOF

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, enhancement)

Comment 1

[Henri Sivonen (:hsivonen)]

errListUnclosedStartTags is not available to C++, so this patch doesn't compile.

Comment 2

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1650066 - Correct error for EOF in “in template” state

Doing errUnclosedElements(eltPos, "template") for EOF in the “in
template” state results in the error message “End tag template seen, but
there were open elements”, which is all wrong because the actual problem is
that though a template end tag was expected, EOF was reached without a
template end tag being seen.

So let’s instead when we reach this just report the list of open elements.

Comment 3

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1650066 fixup - Avoid calling errListUnclosedStartTags in C++.

Comment 4

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1650066 preparation - Add errListUnclosedStartTags for HTML tree builder error reporting.

Comment 5

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1650066 preparation - Add errListUnclosedStartTags for HTML tree builder error reporting.

Comment 6

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1650066 - Correct error for EOF in “in template” state

Doing errUnclosedElements(eltPos, "template") for EOF in the “in
template” state results in the error message “End tag template seen, but
there were open elements”, which is all wrong because the actual problem is
that though a template end tag was expected, EOF was reached without a
template end tag being seen.

So let’s instead when we reach this just report the list of open elements.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e85069514f9
preparation - Add errListUnclosedStartTags for HTML tree builder error reporting. r=smaug
https://hg.mozilla.org/integration/autoland/rev/2f58a8d24883
Correct error for EOF in “in template” state r=smaug

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/6e85069514f9
https://hg.mozilla.org/mozilla-central/rev/2f58a8d24883

Comment 9

[Henri Sivonen (:hsivonen)]

https://github.com/validator/htmlparser/commit/424644dde37a6b7895e310ac062916de416a7c50