1650113 - error: ‘class gfxPlatformGtk’ has no member named ‘UseDMABufTextures’

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

trunk fails to build with gcc-9 and 10 with:

In file included from Unified_cpp_gfx_layers5.cpp:110:
/root/firefox-gcc-last/gfx/layers/client/ContentClient.cpp: In static member function ‘static already_AddRefed<mozilla::layers::ContentClient> mozilla::layers::ContentClient::CreateContentClient(mozilla::layers::CompositableForwarder*)’:
/root/firefox-gcc-last/gfx/layers/client/ContentClient.cpp:89:40: error: ‘class gfxPlatformGtk’ has no member named ‘UseDMABufTextures’
   89 |     if (gfxPlatformGtk::GetPlatform()->UseDMABufTextures()) {
      |                                        ^~~~~~~~~~~~~~~~~
dom/media/platforms/ffmpeg/libav54
gmake[4]: *** [/root/firefox-gcc-last/config/rules.mk:748: Unified_cpp_gfx_layers5.o] Error 1

Comment 1

[Jan Keromnes [:janx]]

Also fails with ~/.mozbuild/clang/bin/clang-9 (by the way, shouldn't that be clang-10 now?)

 1:36.64 dom/media/platforms/ffmpeg/libav55
 1:58.43 In file included from Unified_cpp_gfx_layers5.cpp:110:
 1:58.43 /workspace/gecko-dev/gfx/layers/client/ContentClient.cpp:89:40: error: no member named 'UseDMABufTextures' in 'gfxPlatformGtk'
 1:58.43     if (gfxPlatformGtk::GetPlatform()->UseDMABufTextures()) {
 1:58.43         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ^
 2:07.53 BUILDSTATUS BUILD_VERBOSE dom/media/platforms/ffmpeg/ffmpeg57
 2:08.24 dom/media/platforms/ffmpeg/ffmpeg58
 2:16.74 1 error generated.
 2:17.54 make[4]: *** [/workspace/gecko-dev/config/rules.mk:748: Unified_cpp_gfx_layers5.o] Error 1
 2:17.54 make[3]: *** [/workspace/gecko-dev/config/recurse.mk:72: gfx/layers/target-objects] Error 2
 2:17.63 make[3]: *** Waiting for unfinished jobs....

Probaby a duplicate of https://bugzilla.mozilla.org/show_bug.cgi?id=1649895

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Salut Jan

I guess it is the gtk version.
Martin, does it ring a bell?

Comment 3

[Sylvestre Ledru [:Sylvestre]]

checking for gtk+-wayland-3.0 >= 3.10 xkbcommon >= 0.4.1 libdrm >= 2.4... no
[...]
checking for gtk+-3.0 >= 3.4.0 gtk+-unix-print-3.0 glib-2.0 gobject-2.0 gio-unix-2.0 ... yes
checking MOZ_GTK3_CFLAGS... -pthread -I/usr/include/gtk-3.0/unix-print -I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/gtk-3.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/fribidi -I/usr/include/harfbuzz -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/gio-unix-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include
checking MOZ_GTK3_LIBS... -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -lharfbuzz -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0
checking for gtk+-2.0 >= 2.18.0 gtk+-unix-print-2.0 glib-2.0 >= 2.22 gobject-2.0 gio-unix-2.0 gdk-x11-2.0... yes
checking MOZ_GTK2_CFLAGS... -pthread -I/usr/include/gtk-2.0 -I/usr/include/gtk-unix-print-2.0 -I/usr/include/gtk-2.0 -I/usr/include/atk-1.0 -I/usr/include/gio-unix-2.0 -I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/pango-1.0 -I/usr/include/fribidi -I/usr/include/harfbuzz -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include
checking MOZ_GTK2_LIBS... -lgtk-x11-2.0 -latk-1.0 -lpangoft2-1.0 -lfontconfig -lfreetype -lgio-2.0 -lgdk-x11-2.0 -lpangocairo-1.0 -lpango-1.0 -lharfbuzz -lcairo -lgdk_pixbuf-2.0 -lgobject-2.0 -lglib-2.0

on a debian stable

Comment 4

[Martin Stránský [:stransky] (ni? me)]

I see. It turns off Walyland support, which also means you don't get dmabuf/va-api on X11.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1650113 [Linux] Use DMABufTextures only when Wayland support is build, r?sotaro

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f044c37af6f
[Linux] Use DMABufTextures only when Wayland support is build, r=sotaro

Comment 9

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/4f044c37af6f