165015 - hookup cmd-shift-R for shift-reload

Status: RESOLVED FIXED

(Camino Graveyard :: Accessibility, defect)

Description

[sairuh (rarely reading bugmail)]

spun off from bug 164659. shift-clicking the Reload button in the navigation
toolbar works, but cmd-shift-R doesn't work (just get an error beep).

bonus points: dynamically update the menu to reflect when shift-reload would be
needed for a page. ie, label should update to "Reload Page shift-cmd-R".

Comment 1

[Ludovic Hirlimann [:Usul]]

still true with 2003090102 on 10.2.6.

Comment 2

[Brion Vibber]

Still not working in 2004051308 (v0.8b).

Comment 3

[Samuel Sidler (old account; do not CC)]

This seems fairly easy. Wevah's going to work on it, so targeting for 1.0.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #3)
> This seems fairly easy. Wevah's going to work on it, so targeting for 1.0.

1.0 or 1.1.  The target currently reads 1.1 :-)

Comment 5

[Samuel Sidler (old account; do not CC)]

(In reply to comment #4)
> 
> 1.0 or 1.1.  The target currently reads 1.1 :-)
> 

Whoops. 1.0. :)

Comment 6

[Wevah (Nate Weaver)]

Officially taking this.

Comment 7

[Wevah (Nate Weaver)]

As for the dynamic menu updating, we'll do that when we drop 10.2 support.

Comment 8

[Wevah (Nate Weaver)]

Attachment: Proposed patch for hooking up Command-Shift-R to force-reload.

Here's a patch. Another small one.

Comment 9

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 179816 [details] [diff] [review]
Proposed patch for hooking up Command-Shift-R to force-reload.

sr=pink

Comment 10

[Wevah (Nate Weaver)]

Any reason this was never checked in?

Comment 11

[Wevah (Nate Weaver)]

Poke for smfr.

Comment 12

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #10)
> Any reason this was never checked in?

Hrm, here it is another month-plus later...I'm guessing because neither josh nor
smfr nor pink are cc'd, they've forgotten all about checking this in?

Does the patch still apply?

Comment 13

[Wevah (Nate Weaver)]

I have no idea. I've harrassed smfr about it on IRC a few times, though.

Comment 14

[Wevah (Nate Weaver)]

(In reply to comment #13)
> [...]harrassed[...].

Harassed. Bah.

Comment 15

[Simon Fraser [no longer active]]

Checked in. Thanks Wevah!

Comment 16

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Er, this landed, so removing the obsolete ? flag.  Sorry for the noise.

Should we start a (meta)bug for all the things that need dynamically updating
menu items when we drop 10.2 support?