Closed
Bug 1650155
Opened 6 years ago
Closed 6 years ago
Rename PromiseTestUtils whitelistRejectionsGlobally to allowlist
Categories
(Firefox :: General, defect, P1)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 80
| Tracking | Status | |
|---|---|---|
| firefox80 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
This API currently fails the rejected-words linter and should be renamed.
https://searchfox.org/mozilla-central/search?path=&q=whitelistRejectionsGlobally
allowlistRejectionsGlobally doesn't really sound right, whitelist feels like a verb in the initial method name. Maybe allowRejectionsGlobally?
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
Depends on D82059
|
|
Assignee | |
Comment 3•6 years ago
|
||
Depends on D82061
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/445c63008198
Rename PromiseTestUtils.whitelistRejectionsGlobally to allowMatchingRejectionsGlobally r=Gijs
https://hg.mozilla.org/integration/autoland/rev/e5c998763926
Remove remaining mentions of whitelist in files using allowMatchingRejectionsGlobally r=Gijs
https://hg.mozilla.org/integration/autoland/rev/8abe700c3720
Update exclude list in rejected-words.yml after renaming whitelistRejectionsGlobally to allowMatchingRejectionsGlobally r=Gijs
Pushed by malexandru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/467214e62fcb
Fix allowMatchingRejectionsGlobally name in browser_uncaught_rejection_expected.js
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/445c63008198
https://hg.mozilla.org/mozilla-central/rev/e5c998763926
https://hg.mozilla.org/mozilla-central/rev/8abe700c3720
https://hg.mozilla.org/mozilla-central/rev/467214e62fcb
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox80:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 80
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/c400f9634fd1
Port bug 1650155 - Rename PromiseTestUtils.whitelistRejectionsGlobally to allowMatchingRejectionsGlobally. rs=bustage-fix
You need to log in
before you can comment on or make changes to this bug.
Description
•