1650163 - RemoteType should be nsCString

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, enhancement, P3)

Description

[Nika Layzell [:nika] (ni? for response)]

We never put wide characters into RemoteType values, and most code which works with them in C++ would benefit from declaring them as narrow nsCString strings. This bug is to track switching them over.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1650163 - Part 1: Switch native remoteType values to nsCString,

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1650163 - Part 2: Use new ""_ns string literals for REMOTE_TYPE defines,

Comment 3

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1650163 - Part 2: Add a NOT_REMOTE_TYPE define to clarify calling code,

Comment 4

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1650163 - Part 3: Move REMOTE_TYPE defines to a separate header,

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5fb444c35764
Part 1: Switch native remoteType values to nsCString, r=farre
https://hg.mozilla.org/integration/autoland/rev/c41753a56f5a
Part 2: Add a NOT_REMOTE_TYPE define to clarify calling code, r=farre
https://hg.mozilla.org/integration/autoland/rev/4a21afb65254
Part 3: Move REMOTE_TYPE defines to a separate header, r=farre

Comment 6

[Narcis Beleuzu [:NarcisB]]

Backed out for bustages on ChromeUtils.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/d890454d6684f92cf46e6acfd4661dce2ac51bd1
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=308895760&repo=autoland&lineNumber=45375

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79141707d47b
Part 1: Switch native remoteType values to nsCString, r=farre,geckoview-reviewers,agi
https://hg.mozilla.org/integration/autoland/rev/3d2b6908447a
Part 2: Add a NOT_REMOTE_TYPE define to clarify calling code, r=farre
https://hg.mozilla.org/integration/autoland/rev/51d7c644a1e6
Part 3: Move REMOTE_TYPE defines to a separate header, r=farre

Comment 8

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee89deeb4fb6
Backed out 3 changesets for causing bustages in nsContentSecurityManager.cpp

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4203bfefb531
Part 1: Switch native remoteType values to nsCString, r=farre,geckoview-reviewers,agi
https://hg.mozilla.org/integration/autoland/rev/31d4b51243f7
Part 2: Add a NOT_REMOTE_TYPE define to clarify calling code, r=farre
https://hg.mozilla.org/integration/autoland/rev/a41eb208ee64
Part 3: Move REMOTE_TYPE defines to a separate header, r=farre

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/4203bfefb531
https://hg.mozilla.org/mozilla-central/rev/31d4b51243f7
https://hg.mozilla.org/mozilla-central/rev/a41eb208ee64