1650260 - Crash in [@ mozilla::BlankAudioDataCreator::Create]

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Andrew McCreight [:mccr8]]

This bug is for crash report bp-efeeb18a-2260-414c-9006-529230200701.

Top 10 frames of crashing thread:

0 xul.dll mozilla::BlankAudioDataCreator::Create dom/media/platforms/agnostic/BlankDecoderModule.cpp:108
1 xul.dll mozilla::DummyMediaDataDecoder::Decode dom/media/platforms/agnostic/DummyMediaDataDecoder.cpp:39
2 xul.dll mozilla::detail::ProxyFunctionRunnable<`lambda at /builds/worker/checkouts/gecko/dom/media/platforms/wrappers/AudioTrimmer.cpp:36:44', mozilla::MozPromise<nsTArray<RefPtr<mozilla::MediaData> >, mozilla::MediaResult, 1> >::Run xpcom/threads/MozPromise.h:1564
3 xul.dll mozilla::TaskQueue::Runner::Run xpcom/threads/TaskQueue.cpp:158
4 xul.dll nsThreadPool::Run xpcom/threads/nsThreadPool.cpp:299
5 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1234
6 xul.dll NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:513
7 xul.dll mozilla::ipc::MessagePumpForNonMainThreads::Run ipc/glue/MessagePump.cpp:332
8 xul.dll MessageLoop::RunHandler ipc/chromium/src/base/message_loop.cc:327
9 xul.dll MessageLoop::Run ipc/chromium/src/base/message_loop.cc:309

The crash reason is MOZ_DIAGNOSTIC_ASSERT(aSample->mDuration == data->mDuration) (must be equal).

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1650260 - Remove assertion. r?bryce

While the duration returned by the demuxer is typically equal to the decoded size; recent cases have shown that this isn't always the case.

Now, the only way you can encounter this bug is if the user has set some pref. the audio BlankDecoderModule is never used by default; only the video one.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dad5fb0d2403
Remove assertion. r=bryce

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/dad5fb0d2403