1650261 - mach vcs-setup fails on git

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, defect)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

$ ./mach vcs-setup
Error running mach:

    ['vcs-setup']

The error occurred in the implementation of the invoked mach command.

This should never occur and is likely a bug in the implementation of that
command.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file vcs-setup| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

TypeError: configure_git() missing 1 required positional argument: 'top_src_dir'

  File "c:\Users\Kagami\Documents\GitHub\gecko-dev\python/mozboot/mozboot/mach_commands.py", line 99, in vcs_setup
    bootstrap.configure_git(vcs, self._context.state_dir, self._context.topdir)
Sentry is attempting to send 0 pending error messages
Waiting up to 2 seconds
Press Ctrl-Break to quit

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1650261 - Pass git-cinnabar path to configure_git() r=mhentges

D79393 introduced a new parameter to configure_git() but there is a remaining call that does not pass it. This patch fixes it.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1645047

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45973324cbab
Pass git-cinnabar path to configure_git() r=mhentges,rstewart

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/45973324cbab

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:saschanaz, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.