1650336 - Performance marker for webconsole add messages should have a unique label per webconsole UI

Status: RESOLVED FIXED

(DevTools :: Console, task, P3)

Description

[Julian Descottes [:jdescottes]]

The webconsole add messages profile markers are currently all labeled WebConsoleAddMessages. If you have several webconsole UIs reacting to the same messages, the markers will show up "twice" because both UIs will record markers in the parent process.

This typically happens if you have a content toolbox and a BrowserConsole opened simultaneously. Note that this won't happen with a MBT, because the MBT runs in a different Firefox instance.

We could add a suffix to the WebConsoleAddMessages to make it unique per webconsole UI.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

I guess we could use toolbox.sessionId ( and -1 for the browser console), like we do for telemetry events

Comment 2

[Julian Descottes [:jdescottes]]

Profile example with the telemetry session id: https://share.firefox.dev/3gH8APM
(would be great to have title set on the profiler UI)

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1650336 - Add the session id to the WebconsoleAddMessages marker label

An issue with the current approach is that labels are a bit too big for the marker chart sidebar in the profiler UI.
An issue was filed to address this at https://github.com/firefox-devtools/profiler/issues/2638

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26c285b17a81
Add the session id to the WebconsoleAddMessages marker label r=nchevobbe

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/26c285b17a81