1650356 - Clear TRR blocklist when confirmation is done

Status: RESOLVED FIXED

(Core :: Networking: DNS, defect, P2)

Description

[Valentin Gosu [:valentin] (he/him) {{ AFK in July }}]

After a fresh confirmation we should clear the blocklist as we may be under different network conditions now.

Comment 1

[Valentin Gosu [:valentin] (he/him) {{ AFK in July }}]

Attachment: Bug 1650356 - Clear TRR blocklist when confirmation is done r=dragana

Depends on D82169

Comment 2

[Valentin Gosu [:valentin] (he/him) {{ AFK in July }}]

Attachment: Bug 1650356 - Rename TRR Blacklist to TRR blocklist r=dragana

Depends on D82218

Comment 3

[Valentin Gosu [:valentin] (he/him) {{ AFK in July }}]

Attachment: Bug 1650356 - Make the TRRBLStorage a hashtable r=dragana

We also wrap it in a DataMutex to allow use on any thread

Depends on D82219

Comment 4

[Valentin Gosu [:valentin] (he/him) {{ AFK in July }}]

Attachment: Bug 1650356 - Call IsExcludedFromTRR in TRR::SendHTTPRequest r=dragana

Since IsTemporarilyBlocked no longer calls IsExcludedFromTRR we have to do
this explicitly at this call site.

Depends on D82220

Comment 5

[Valentin Gosu [:valentin] (he/him) {{ AFK in July }}]

Attachment: Bug 1650356 - Only trigger confirmation in TRR-first and TRR-only modes r=dragana

Due to a change in timing in this patch, when we reset the confirmation pref
at the end of the test, a TRR request would happen after we changed the prefs
leading to accessing a non-local IP in testing and causing a crash.
This should be gated on being in the correct mode anyway

Depends on D82221

Comment 6

[Phabricator Automation]

Comment on attachment 9161320 [details]
Bug 1650356 - Only trigger confirmation in TRR-first and TRR-only modes r=dragana

Revision D82222 was moved to bug 1649127. Setting attachment 9161320 [details] to obsolete.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6d509edebff
Clear TRR blocklist when confirmation is done r=dragana,necko-reviewers
https://hg.mozilla.org/integration/autoland/rev/831781e4736b
Rename TRR Blacklist to TRR blocklist r=dragana,necko-reviewers
https://hg.mozilla.org/integration/autoland/rev/69f6fd5ca736
Make the TRRBLStorage a hashtable r=dragana,necko-reviewers
https://hg.mozilla.org/integration/autoland/rev/5e545e56ab2b
Call IsExcludedFromTRR in TRR::SendHTTPRequest r=dragana,necko-reviewers

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/d6d509edebff
https://hg.mozilla.org/mozilla-central/rev/831781e4736b
https://hg.mozilla.org/mozilla-central/rev/69f6fd5ca736
https://hg.mozilla.org/mozilla-central/rev/5e545e56ab2b