1650406 - upload-symbols tasks showing up and causing builds with |mach try auto| again

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task, P1)

Description

[Andrew Halberstadt [:ahal]]

Something changed and now all |mach try auto| pushes seem to be scheduling the sym tasks again, and they even seem to be causing opt builds to run.

Comment 1

[Andrew Halberstadt [:ahal]]

This was likely caused by us switching to opt on try instead of shippable:
https://searchfox.org/mozilla-central/source/taskcluster/taskgraph/transforms/upload_symbols.py#74

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1650406 - [ci] Ensure 'upload-symbols' tasks don't cause builds to run with |mach try auto|, r?Callek

Comment 3

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1650406 - [ci] Ensure 'build-win64-aarch64-shippable-no-eme/opt' runs everywhere, r?#firefox-build-system-reviewers

Comment 4

[Andrew Halberstadt [:ahal]]

Hey Nathan and Mike, picking on your two since you commented on the revision (sorry).

But I really need a resolution on this. The one build you both identified should definitely be running has been fixed by:
https://phabricator.services.mozilla.com/D83676

Is that everything?

Comment 5

[Andrew Halberstadt [:ahal]]

Thanks Nathan!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0df4c7fd0d55
[ci] Ensure 'build-win64-aarch64-shippable-no-eme/opt' runs everywhere, r=nalexander
https://hg.mozilla.org/integration/autoland/rev/034864174a6f
[ci] Ensure 'upload-symbols' tasks don't cause builds to run with |mach try auto|, r=Callek,froydnj

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/0df4c7fd0d55
https://hg.mozilla.org/mozilla-central/rev/034864174a6f

Comment 8

[Andrew Halberstadt [:ahal]]

Hm, this seems to have regressed again. Last time this landed the integration tests didn't exist, this time I'll make sure I include a check to ensure it doesn't happen again.

Comment 9

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1650406 - [ci] Add more tests for tasks that shouldn't be running on |mach try auto| pushes, r?Callek

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98bf32dc78b0
[ci] Add more tests for tasks that shouldn't be running on |mach try auto| pushes, r=Callek

Comment 11

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/98bf32dc78b0

Comment 12

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1650406 - [ci] Use 'if-dependencies' with upload-symbols tasks

Depends on D87776

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9cf6e6790048
[ci] Use 'if-dependencies' with upload-symbols tasks r=bhearsum

Comment 14

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9cf6e6790048

Comment 15

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1650406 - [ci] Ensure 'test-verify' tasks use the 'test' strategy with |mach try auto|, r?marco

Comment 16

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1650406 - [taskgraph] Never run 'upload-symbols' tasks with |mach try auto|, r?marco

Depends on D88873

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/910e5a2c9a20
[ci] Ensure 'test-verify' tasks use the 'test' strategy with |mach try auto|, r=marco
https://hg.mozilla.org/integration/autoland/rev/df54683ff216
[taskgraph] Never run 'upload-symbols' tasks with |mach try auto|, r=marco

Comment 18

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/910e5a2c9a20
https://hg.mozilla.org/mozilla-central/rev/df54683ff216