Crash in [@ nsNoDataProtocolContentPolicy::ShouldLoad] (mozilla::css::Loader::CheckContentPolicy)
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox80 | --- | fixed |
People
(Reporter: rafalopilowski1, Assigned: heycam)
References
()
Details
Crash Data
Attachments
(2 files)
This bug is for crash reports:
- bp-2c5be5a3-65d8-4c3e-a5ab-974b40200703
- bp-a8210c32-7d24-424f-8a65-69f7c0200703
- bp-0ba4ca36-6671-4c90-beb9-f75fe0200703
STR:
- Open Firefox Nightly on Android
- Navigate to "https://audio.onet.pl"
Expected behaviour:
Website "https://audio.onet.pl" loads correctly.
Actual behaviour:
Recoverable native crashes [@ nsNoDataProtocolContentPolicy::ShouldLoad] reported to Socorro.
Device information
-
Android device: OnePlus 6 (Android 10, Oxygen 10.3.4)
-
Fenix version:
Nightly 200702 06:03 (Build #21840612)
AC: 49.0.20200701130905, 14d09cc4a
GV: 79.0a1-20200629094229
AS: 61.0.7
Top 10 frames of crashing thread:
0 libxul.so nsNoDataProtocolContentPolicy::ShouldLoad dom/base/nsNoDataProtocolContentPolicy.cpp:44
1 libxul.so nsContentPolicy::CheckPolicy dom/base/nsContentPolicy.cpp:123
2 libxul.so nsContentPolicy::ShouldLoad dom/base/nsContentPolicy.cpp:172
3 libxul.so NS_CheckContentLoadPolicy dom/base/nsContentPolicyUtils.h:226
4 libxul.so mozilla::css::Loader::CheckContentPolicy layout/style/Loader.cpp:898
5 libxul.so mozilla::css::Loader::InternalLoadNonDocumentSheet layout/style/Loader.cpp:2031
6 libxul.so mozilla::css::Loader::LoadSheet layout/style/Loader.cpp:2007
7 libxul.so mozilla::dom::Document::PreloadStyle dom/base/Document.cpp:11577
8 libxul.so mozilla::PreloadService::PreloadStyle uriloader/preload/PreloadService.cpp:198
9 libxul.so mozilla::PreloadService::PreloadOrCoalesce uriloader/preload/PreloadService.cpp:166
Reporter | ||
Updated•4 years ago
|
Reporter | ||
Comment 1•4 years ago
|
||
Also valid for Firefox Nightly from 03.07.2020
Nightly 200703 08:40 (Build #21850844)
AC: 49.0.20200702131412, 1cba216b2
GV: 80.0a1-20200701093012
AS: 61.0.7
Socorro: crash report bp-c8a41ffb-1169-4907-8d1d-b75070200703
Reporter | ||
Comment 2•4 years ago
|
||
Confirmed for Firefox Nightly 80.0a1 on Windows 10 (Build #20200703094420)
Socorro: crash report bp-b09b58c0-1fec-4c46-a40e-5968c0200703
Moving to Core - CSS Parsing and Computation (based on crashing thread), as I've reproduced this bug on both Windows and Android.
Reporter | ||
Updated•4 years ago
|
Assignee | ||
Comment 3•4 years ago
|
||
From the crash location, it looks like ShouldLoad
's aContentLocation
argument is null:
Ultimately that nsIURI
comes from here:
Honza, do we need to null check the URL in case it fails to get created?
Comment 4•4 years ago
|
||
What we should do is check result of NS_NewURI here. If it fails, we can't preload anything. Then probably add non-null check to PreloadService::PreloadOrCoalesceResult as a deeper protection.
Assignee | ||
Comment 5•4 years ago
|
||
Assignee | ||
Comment 6•4 years ago
|
||
Updated•4 years ago
|
Pushed by cmccormack@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/82b8d1e9468a Null check preload URL parsing. r=mayhemer
Comment 8•4 years ago
|
||
bugherder |
Reporter | ||
Comment 9•4 years ago
|
||
Confirming this issue is fixed now for Fenix Nightly (build #22030613
) and Firefox Nightly on Windows (build #20200721094241
)
URL mentioned in this issue now loads properly:
Description
•