1650419 - filesystem_interception.cc is not compiled correctly with PGO

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect, P3)

Description

[Toshihito Kikuchi [:toshi]]

Probably this is a bug in Clang. With PGO, firefox!sandbox::ActualCallParams<7,1024>::CopyParamIn is not compiled correctly regardless Clang's new pass manager. As a workaround, we disable PGO for filesystem_interception.cc until it's fixed. I'll collect information and file a bug in LLVM.

Comment 1

[Toshihito Kikuchi [:toshi]]

This was also caused by https://bugs.llvm.org/show_bug.cgi?id=45858. Let's use this bug to apply the tail merge fix to our version of Clang.

Comment 2

[Toshihito Kikuchi [:toshi]]

Attachment: Bug 1650419 - Backport the tail merge fix to our version of Clang 9.0.1. r=dmajor

This patch applies the fix for https://bugs.llvm.org/show_bug.cgi?id=45858 to
our version of Clang so that we can update Chromium sandbox code (bug 1639030).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8417742ed987
Backport the tail merge fix to our version of Clang 9.0.1.  r=dmajor

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/8417742ed987