Closed
Bug 1650419
Opened 4 years ago
Closed 4 years ago
filesystem_interception.cc is not compiled correctly with PGO
Categories
(Core :: Security: Process Sandboxing, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla80
| Tracking | Status | |
|---|---|---|
| firefox80 | --- | fixed |
People
(Reporter: toshi, Assigned: toshi)
References
Details
Attachments
(1 file)
Probably this is a bug in Clang. With PGO, firefox!sandbox::ActualCallParams<7,1024>::CopyParamIn is not compiled correctly regardless Clang's new pass manager. As a workaround, we disable PGO for filesystem_interception.cc until it's fixed. I'll collect information and file a bug in LLVM.
|
Assignee | |
Updated•4 years ago
|
Severity: -- → S3
Priority: -- → P3
|
|
Assignee | |
Comment 1•4 years ago
|
||
This was also caused by https://bugs.llvm.org/show_bug.cgi?id=45858. Let's use this bug to apply the tail merge fix to our version of Clang.
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 2•4 years ago
|
||
This patch applies the fix for https://bugs.llvm.org/show_bug.cgi?id=45858 to
our version of Clang so that we can update Chromium sandbox code (bug 1639030).
Pushed by abutkovits@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8417742ed987 Backport the tail merge fix to our version of Clang 9.0.1. r=dmajor
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox80:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in
before you can comment on or make changes to this bug.
Description
•