1650520 - VAAPI on non-supported GLX: Crash in [@ mozilla::layers::AsyncImagePipelineManager::UpdateImageKeys]

Status: RESOLVED DUPLICATE of bug 1650748

(Core :: Graphics: WebRender, defect, P3)

Description

[lilydjwg]

This bug is for crash report bp-807395bc-601e-4a0e-8a8f-bb9bf0200704.

Top 10 frames of crashing thread:

0 libxul.so mozilla::layers::AsyncImagePipelineManager::UpdateImageKeys gfx/layers/wr/AsyncImagePipelineManager.cpp:243
1 libxul.so mozilla::layers::AsyncImagePipelineManager::ApplyAsyncImageForPipeline gfx/layers/wr/AsyncImagePipelineManager.cpp:341
2 libxul.so mozilla::layers::AsyncImagePipelineManager::ApplyAsyncImagesOfImageBridge gfx/layers/wr/AsyncImagePipelineManager.cpp:331
3 libxul.so mozilla::layers::WebRenderBridgeParent::MaybeGenerateFrame gfx/layers/wr/WebRenderBridgeParent.cpp:2026
4 libxul.so mozilla::layers::WebRenderBridgeParent::CompositeToTarget gfx/layers/wr/WebRenderBridgeParent.cpp:1985
5 libxul.so mozilla::layers::CompositorVsyncScheduler::Composite gfx/layers/ipc/CompositorVsyncScheduler.cpp:263
6 libxul.so mozilla::detail::RunnableMethodImpl<mozilla::layers::CompositorVsyncScheduler*, void  xpcom/threads/nsThreadUtils.h:1240
7 libxul.so nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1234
8 libxul.so mozilla::ipc::MessagePumpForNonMainThreads::Run xpcom/threads/nsThreadUtils.cpp:513
9 libxul.so MessageLoop::Run ipc/chromium/src/base/message_loop.cc:309

I've set media.ffmpeg.vaapi.enabled and media.ffmpeg.vaapi-drm-display.enabled to true, with webrender enabled, and got the GPU Process crashes for playing mp4 / h264 video files locally.

It crashes immediately if egl is not used, and crashes some seconds later if MOZ_X11_EGL=1.

Comment 1

[lilydjwg]

There are other reports e.g. bp-cc1965c4-a3d9-46fc-ad66-6ac7e0200704 which looks differently (and I have quite a few locally and don't know if they are the same or not).

Comment 2

[Alastor Wu [:alwu]]

It crashes on the gfx layer's code, so maybe graphic team can take a look first to see what's happened. As it happened when enabling VAAPI, so set it to block the metabug of VAAPI.

Comment 3

[Kris Taeleman (:ktaeleman)]

@nical: Looks like you and sotaro know this code. Could you take a look at this?

Comment 4

[Nicolas Silva [:nical]]

It didn't reproduce after switching the two prefs, there's probably other bits of environment required to run into this. It's not a configuration we ship and the VAAPI work is still in flux, so we can revisit this when egl-linux-vaapi and dependencies are getting closer to shippable.

Comment 5

[lilydjwg]

I no longer reproduce this crash with a new version 80.0a1 (2020-07-07). Either it's fixed or something on my side got wrong four days ago.

Comment 6

[Gabriele Svelto [:gsvelto]]

There's still a steady steam of crashes with this signature coming from nightly users, I suggest reopening this until the issue is addressed. The volume is fairly high especially given these are only Linux nightly users with WebRender enabled.

Comment 7

[Darkspirit]

Last crash happened with build 2020-07-22_094100.
bug 1650748 shipped with build 2020-07-23_095657.