Closed Bug 1650552 Opened 4 years ago Closed 4 years ago

Perma toolkit/components/antitracking/test/browser/browser_hasStorageAccess.js | Has storage access - false == true - got false, expected true (operator ==) when Gecko merges to Beta on 2020-07-27

Categories

(Core :: Privacy: Anti-Tracking, defect)

Product:
Core
Component:
Privacy: Anti-Tracking
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla80
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox77 --- unaffected
firefox78 --- unaffected
firefox79 --- unaffected
firefox80 + verified

People

(Reporter: apavel, Assigned: dimi)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1650552 - Update browser_hasStorageAccess to honor network.cookie.rejectForeignWithExceptions.enabled pref r=timhuang
47 bytes, text/x-phabricator-request
Details | Review

Central as Beta simulation

Treeherder link: https://treeherder.mozilla.org/#/jobs?repo=try&selectedTaskRun=UMLzcednSY68L961c7qlNQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=74d57bc6a5b5161ab19a51b57de9117aba82678d

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=308563575&repo=try&lineNumber=26403

[task 2020-07-04T11:51:58.526Z] 11:51:58 INFO - TEST-START | toolkit/components/antitracking/test/browser/browser_hasStorageAccess.js
[task 2020-07-04T11:51:58.577Z] 11:51:58 INFO - GECKO(1370) | [Child 1392: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 12 (0x130508350) [pid = 1392] [serial = 1719] [outer = 0x0] [url = https://tracking.example.org/browser/toolkit/components/antitracking/test/browser/3rdParty.html]
[task 2020-07-04T11:51:58.577Z] 11:51:58 INFO - GECKO(1370) | [Child 1392: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 11 (0x1471bebc0) [pid = 1392] [serial = 1725] [outer = 0x0] [url = https://tracking.example.org/browser/toolkit/components/antitracking/test/browser/3rdParty.html]
[task 2020-07-04T11:51:58.577Z] 11:51:58 INFO - GECKO(1370) | [Child 1392: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 10 (0x1471be9f0) [pid = 1392] [serial = 1722] [outer = 0x0] [url = https://another-tracking.example.net/browser/toolkit/components/antitracking/test/browser/3rdParty.html]
[task 2020-07-04T11:51:58.708Z] 11:51:58 INFO - GECKO(1370) | [Child 1376: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x1497c4000 == 4 [pid = 1376] [id = {a7b4061c-0c58-bb4a-b0cf-5cc6da90ac0c}]
[task 2020-07-04T11:51:58.710Z] 11:51:58 INFO - GECKO(1370) | [Child 1376: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 19 (0x106d0cb70) [pid = 1376] [serial = 1452] [outer = 0x0]
[task 2020-07-04T11:51:58.717Z] 11:51:58 INFO - GECKO(1370) | [Child 1376: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 20 (0x1497eb000) [pid = 1376] [serial = 1453] [outer = 0x106d0cb70]
[task 2020-07-04T11:51:59.006Z] 11:51:59 INFO - GECKO(1370) | [Child 1376: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 21 (0x1497f8400) [pid = 1376] [serial = 1454] [outer = 0x106d0cb70]
[task 2020-07-04T11:51:59.174Z] 11:51:59 INFO - GECKO(1370) | [Child 1376: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x14d838400 == 5 [pid = 1376] [id = {5f1e7cc0-2dc5-ad41-8ab8-ccd6c8af6cbb}]
[task 2020-07-04T11:51:59.175Z] 11:51:59 INFO - GECKO(1370) | [Child 1376: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 22 (0x106d0e870) [pid = 1376] [serial = 1455] [outer = 0x0]
[task 2020-07-04T11:51:59.175Z] 11:51:59 INFO - GECKO(1370) | [Child 1376: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 23 (0x14d83b000) [pid = 1376] [serial = 1456] [outer = 0x106d0e870]
[task 2020-07-04T11:51:59.358Z] 11:51:59 INFO - GECKO(1370) | [Child 1376: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 24 (0x14d83fc00) [pid = 1376] [serial = 1457] [outer = 0x106d0e870]
[task 2020-07-04T11:51:59.656Z] 11:51:59 INFO - GECKO(1370) | [Child 1389: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x10d5a1c00 == 5 [pid = 1389] [id = {4e7e1a52-b2d4-8641-9451-da08a012a10e}]
[task 2020-07-04T11:51:59.656Z] 11:51:59 INFO - GECKO(1370) | [Child 1389: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 11 (0x13edd3180) [pid = 1389] [serial = 1773] [outer = 0x0]
[task 2020-07-04T11:51:59.656Z] 11:51:59 INFO - GECKO(1370) | [Child 1389: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 12 (0x145e6fc00) [pid = 1389] [serial = 1774] [outer = 0x13edd3180]
[task 2020-07-04T11:51:59.814Z] 11:51:59 INFO - GECKO(1370) | [Child 1376: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x146bcd800 == 6 [pid = 1376] [id = {4102348e-d706-9047-818c-ef4d34dbf024}]
[task 2020-07-04T11:51:59.814Z] 11:51:59 INFO - GECKO(1370) | [Child 1376: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 25 (0x106d0f180) [pid = 1376] [serial = 1458] [outer = 0x0]

[task 2020-07-04T11:52:04.972Z] 11:52:04 INFO - TEST-PASS | toolkit/components/antitracking/test/browser/browser_hasStorageAccess.js | callbackAfterRemoval must be passed when accessRemoval is non-null -
[task 2020-07-04T11:52:04.972Z] 11:52:04 INFO - Creating a new tab
[task 2020-07-04T11:52:04.973Z] 11:52:04 INFO - Creating a 3rd party content
[task 2020-07-04T11:52:04.973Z] 11:52:04 INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://example.net/browser/toolkit/components/antitracking/test/browser/page.html" line: 0}]
[task 2020-07-04T11:52:04.973Z] 11:52:04 INFO - Sending code to the 3rd party content
[task 2020-07-04T11:52:04.973Z] 11:52:04 INFO - Buffered messages finished
[task 2020-07-04T11:52:04.974Z] 11:52:04 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/antitracking/test/browser/browser_hasStorageAccess.js | Has storage access - false == true - got false, expected true (operator ==)
[task 2020-07-04T11:52:04.974Z] 11:52:04 INFO - Stack trace:
[task 2020-07-04T11:52:04.974Z] 11:52:04 INFO - ok@resource://specialpowers/SpecialPowersSandbox.jsm:87:21
[task 2020-07-04T11:52:04.974Z] 11:52:04 INFO - msg@chrome://mochitests/content/browser/toolkit/components/antitracking/test/browser/antitracking_head.js:635:19
[task 2020-07-04T11:52:04.975Z] 11:52:04 INFO - TEST-PASS | toolkit/components/antitracking/test/browser/browser_hasStorageAccess.js | No console messages should be generated -
[task 2020-07-04T11:52:04.975Z] 11:52:04 INFO - TEST-PASS | toolkit/components/antitracking/test/browser/browser_hasStorageAccess.js | Checking cookie blocking notifications -
[task 2020-07-04T11:52:04.975Z] 11:52:04 INFO - Removing the tab
[task 2020-07-04T11:52:04.976Z] 11:52:04 INFO - Leaving test bound
[task 2020-07-04T11:52:04.976Z] 11:52:04 INFO - Entering test bound
[task 2020-07-04T11:52:04.976Z] 11:52:04 INFO - Starting blocking cookieBehavior (2) without allow list test Test whether 3rd-party non-tracker frame has storage access when storage permission is granted before running in a normal window with iframe sandbox set to null and access removal set to null and third party page set to http://not-tracking.example.com/browser/toolkit/components/antitracking/test/browser/3rdParty.html and top page set to http://example.net/browser/toolkit/components/antitracking/test/browser/page.html
[task 2020-07-04T11:52:04.976Z] 11:52:04 INFO - TEST-PASS | toolkit/components/antitracking/test/browser/browser_hasStorageAccess.js | callbackAfterRemoval must be passed when accessRemoval is non-null -
[task 2020-07-04T11:52:04.976Z] 11:52:04 INFO - Creating a new tab
[task 2020-07-04T11:52:04.977Z] 11:52:04 INFO - GECKO(1370) | [Child 1376: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x146bd2800 == 5 [pid = 1376] [id = {81bb3cff-3c3b-8d42-9a64-11a29c961aa0}]
[task 2020-07-04T11:52:04.977Z] 11:52:04 INFO - GECKO(1370) | [Child 1376: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 16 (0x106d0cb70) [pid = 1376] [serial = 1500] [outer = 0x0]
[task 2020-07-04T11:52:04.985Z] 11:52:04 INFO - GECKO(1370) | [Child 1376: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 17 (0x1497ea800) [pid = 1376] [serial = 1501] [outer = 0x106d0cb70]
[task 2020-07-04T11:52:05.012Z] 11:52:05 INFO - GECKO(1370) | [Child 1376: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x146bd2c00 == 4 [pid = 1376] [id = {d5051fde-063e-8b47-a4d3-a975b3e44add}] [url = http://example.net/browser/toolkit/components/antitracking/test/browser/page.html]
[task 2020-07-04T11:52:05.013Z] 11:52:05 INFO - GECKO(1370) | [Child 1376: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x146bcec00 == 3 [pid = 1376] [id = {94fb0b23-30c3-0445-b349-4662f39fa04d}] [url = http://not-tracking.example.com/browser/toolkit/components/antitracking/test/browser/3rdParty.html]
[task 2020-07-04T11:52:05.013Z] 11:52:05 INFO - GECKO(1370) | [Child 1376: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 16 (0x1497c3000) [pid = 1376] [serial = 1489] [outer = 0x0] [url = about:blank]
[task 2020-07-04T11:52:05.013Z] 11:52:05 INFO - GECKO(1370) | [Child 1376: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 15 (0x1497ec000) [pid = 1376] [serial = 1484] [outer = 0x0] [url = http://example.net/browser/toolkit/components/antitracking/test/browser/page.html]
[task 2020-07-04T11:52:05.013Z] 11:52:05 INFO - GECKO(1370) | [Child 1376: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 14 (0x1497f0400) [pid = 1376] [serial = 1486] [outer = 0x0] [url = about:blank]
[task 2020-07-04T11:52:05.014Z] 11:52:05 INFO - GECKO(1370) | [Child 1376: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 13 (0x1497f6400) [pid = 1376] [serial = 1487] [outer = 0x0] [url = http://not-tracking.example.com/browser/toolkit/components/antitracking/test/browser/3rdParty.html]
[task 2020-07-04T11:52:05.064Z] 11:52:05 INFO - GECKO(1370) | [Child 1376: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 14 (0x1497ecc00) [pid = 1376] [serial = 1502] [outer = 0x106d0cb70]
[task 2020-07-04T11:52:05.192Z] 11:52:05 INFO - Creating a 3rd party content
[task 2020-07-04T11:52:05.211Z] 11:52:05 INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://example.net/browser/toolkit/components/antitracking/test/browser/page.html" line: 0}]
[task 2020-07-04T11:52:05.212Z] 11:52:05 INFO - GECKO(1370) | [Child 1376: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x1497cd800 == 4 [pid = 1376] [id = {c38b40b5-0882-0f42-b0d0-167436cdbe8d}]
[task 2020-07-04T11:52:05.212Z] 11:52:05 INFO - GECKO(1370) | [Child 1376: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 15 (0x106d0ede0) [pid = 1376] [serial = 1503] [outer = 0x0]
[task 2020-07-04T11:52:05.220Z] 11:52:05 INFO - GECKO(1370) | [Child 1376: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 16 (0x1497f3c00) [pid = 1376] [serial = 1504] [outer = 0x106d0ede0]
[task 2020-07-04T11:52:05.271Z] 11:52:05 INFO - GECKO(1370) | [Child 1376: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 17 (0x1497f9000) [pid = 1376] [serial = 1505] [outer = 0x106d0ede0]
[task 2020-07-04T11:52:05.271Z] 11:52:05 INFO - GECKO(1370) | [Child 1376: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 16 (0x106d0ec10) [pid = 1376] [serial = 1488] [outer = 0x0] [url = http://example.net/browser/toolkit/components/antitracking/test/browser/page.html]
[task 2020-07-04T11:52:05.272Z] 11:52:05 INFO - GECKO(1370) | [Child 1376: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 15 (0x106d0c7d0) [pid = 1376] [serial = 1491] [outer = 0x0] [url = http://not-tracking.example.com/browser/toolkit/components/antitracking/test/browser/3rdParty.html]
[task 2020-07-04T11:52:05.345Z] 11:52:05 INFO - Sending code to the 3rd party content
[task 2020-07-04T11:52:05.345Z] 11:52:05 INFO - TEST-PASS | toolkit/components/antitracking/test/browser/browser_hasStorageAccess.js | Doesn't yet have storage access - true == true -
[task 2020-07-04T11:52:05.346Z] 11:52:05 INFO - TEST-PASS | toolkit/components/antitracking/test/browser/browser_hasStorageAccess.js | No console messages should be generated -
[task 2020-07-04T11:52:05.346Z] 11:52:05 INFO - TEST-PASS | toolkit/components/antitracking/test/browser/browser_hasStorageAccess.js | Checking cookie blocking notifications -
[task 2020-07-04T11:52:05.346Z] 11:52:05 INFO - Removing the tab
[task 2020-07-04T11:52:05.395Z] 11:52:05 INFO - Leaving test bound

Dimi, please take a look.

Flags: needinfo?(dlee)
See Also: → 1650641
See Also: → 1650639
Assignee: nobody → dlee
Status: NEW → ASSIGNED
Flags: needinfo?(dlee)
Pushed by dlee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/48bc3f553e99 Update browser_hasStorageAccess to honor network.cookie.rejectForeignWithExceptions.enabled pref r=timhuang

Does this patch also handle the failures from the duplicates?

Flags: needinfo?(dlee)

(In reply to Julien Cristau [:jcristau] from comment #5)

Does this patch also handle the failures from the duplicates?

I don't think so, I'll check the other bugs.

Flags: needinfo?(dlee)

https://hg.mozilla.org/mozilla-central/rev/48bc3f553e99

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox80: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: