1650615 - several style issues in library on macOS Big Sur Beta

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect, P2)

Description

[Sören Hentzschel]

Attachment: library.png

There are several style issues with the library on macOS Big Sur Developer Beta 1.

1. the search input field has the same background color as the window itself and the border color is very different so without the placeholder text the input field would be almost invisible. I guess it has a11y implications due to the bad color contrast.
2. The alignment of the icon and the placeholder text in the search input field is no longer okay.
3. Similar to the search input field the buttons have a different color now with a bad color constrast.
4. If you press on one of the buttons you can see another style issue with the separators of the dropdown menus.

Comment 1

[Joe McCabe]

Behavior persists in Big Sur beta 3.

Comment 2

[Haik Aftandilian [:haik]]

[Tracking Requested - why for this release]: Look and feel bug affecting macOS 11.

Comment 3

[Julien Cristau [:jcristau]]

What's the status here, is anyone working on these issues?

Comment 4

[Haik Aftandilian [:haik]]

I'm working on bug 1656301 which is more user-visible. Nobody is working on this one right now.

Comment 5

[Haik Aftandilian [:haik]]

Attachment: Bug 1650615 - Part 1 - Manually draw toolbar button backgrounds on Big Sur r?mstange!

Draw toolbar button segment backgrounds manually on Big Sur to workaround a problem where they are filled with the toolbar gradient.

Comment 6

[Haik Aftandilian [:haik]]

Attachment: Bug 1650615 - Part 2 - Library search field has incorrect styling r?mstange!

For Big Sur toolbar search fields, don't return YES from _isToolbarMode(). And adjust the search field border for better spacing after the search icon.

Depends on D93578

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8fe70627a94
Part 1 - Manually draw toolbar button backgrounds on Big Sur r=mstange
https://hg.mozilla.org/integration/autoland/rev/14425d338205
Part 2 - Library search field has incorrect styling r=mstange

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d8fe70627a94
https://hg.mozilla.org/mozilla-central/rev/14425d338205

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Did we want to uplift these patches to ESR78? They graft cleanly as-landed.

Comment 10

[Haik Aftandilian [:haik]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #9)

Did we want to uplift these patches to ESR78? They graft cleanly as-landed.

Yes, we'll want this in the ESR to support Big Sur. I'll file an uplift request.

Comment 12

[Haik Aftandilian [:haik]]

Comment on attachment 9181644 [details]
Bug 1650615 - Part 1 - Manually draw toolbar button backgrounds on Big Sur r?mstange!

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: The problem causes the Firefox Library window to appear buggy/unpolished on macOS 11 which is unofficially expected to release in the coming month. Specifically the search field appears grayed out and the buttons of a gray instead of off-white background.
• User impact if declined: The Library window appears buggy/unpolished when running on macOS 11.
• Fix Landed on Version: 83
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): The risk to taking this patch is low/medium because

1. the changes are limited to macOS 11
2. the changes are for Mac-specific UI styling and should only affect appearance of some dialogs and not other browser functionality

• String or UUID changes made by this patch:

Comment 13

[Julien Cristau [:jcristau]]

Comment on attachment 9181644 [details]
Bug 1650615 - Part 1 - Manually draw toolbar button backgrounds on Big Sur r?mstange!

approved for 78.5

Comment 14

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-esr78/rev/be63c5a407aa
https://hg.mozilla.org/releases/mozilla-esr78/rev/c63b47ff23db

Comment 15

[Cristian Fogel [:cfogel]]

Verified with the above linked (78.5)ESR build and 83.0b10 on Release Candidate - macOS(11.0.1) Beta.

• lines are looking ok;
• no background issues for the library items and menus.