several style issues in library on macOS Big Sur Beta
Categories
(Core :: Widget: Cocoa, defect, P2)
Tracking
()
People
(Reporter: soeren.hentzschel, Assigned: haik)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
335.21 KB,
image/png
|
Details | |
47 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-esr78+
|
Details | Review |
47 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-esr78+
|
Details | Review |
There are several style issues with the library on macOS Big Sur Developer Beta 1.
- the search input field has the same background color as the window itself and the border color is very different so without the placeholder text the input field would be almost invisible. I guess it has a11y implications due to the bad color contrast.
- The alignment of the icon and the placeholder text in the search input field is no longer okay.
- Similar to the search input field the buttons have a different color now with a bad color constrast.
- If you press on one of the buttons you can see another style issue with the separators of the dropdown menus.
Updated•5 years ago
|
Updated•5 years ago
|
Comment 1•5 years ago
|
||
Behavior persists in Big Sur beta 3.
Assignee | ||
Comment 2•4 years ago
|
||
[Tracking Requested - why for this release]: Look and feel bug affecting macOS 11.
Updated•4 years ago
|
Updated•4 years ago
|
Comment 3•4 years ago
|
||
What's the status here, is anyone working on these issues?
Assignee | ||
Comment 4•4 years ago
|
||
I'm working on bug 1656301 which is more user-visible. Nobody is working on this one right now.
Updated•4 years ago
|
Assignee | ||
Comment 5•4 years ago
|
||
Draw toolbar button segment backgrounds manually on Big Sur to workaround a problem where they are filled with the toolbar gradient.
Updated•4 years ago
|
Assignee | ||
Comment 6•4 years ago
|
||
For Big Sur toolbar search fields, don't return YES from _isToolbarMode(). And adjust the search field border for better spacing after the search icon.
Depends on D93578
Comment 8•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d8fe70627a94
https://hg.mozilla.org/mozilla-central/rev/14425d338205
Comment 9•4 years ago
|
||
Did we want to uplift these patches to ESR78? They graft cleanly as-landed.
Assignee | ||
Comment 10•4 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #9)
Did we want to uplift these patches to ESR78? They graft cleanly as-landed.
Yes, we'll want this in the ESR to support Big Sur. I'll file an uplift request.
Assignee | ||
Comment 12•4 years ago
|
||
Comment on attachment 9181644 [details]
Bug 1650615 - Part 1 - Manually draw toolbar button backgrounds on Big Sur r?mstange!
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: The problem causes the Firefox Library window to appear buggy/unpolished on macOS 11 which is unofficially expected to release in the coming month. Specifically the search field appears grayed out and the buttons of a gray instead of off-white background.
- User impact if declined: The Library window appears buggy/unpolished when running on macOS 11.
- Fix Landed on Version: 83
- Risk to taking this patch: Medium
- Why is the change risky/not risky? (and alternatives if risky): The risk to taking this patch is low/medium because
- the changes are limited to macOS 11
- the changes are for Mac-specific UI styling and should only affect appearance of some dialogs and not other browser functionality
- String or UUID changes made by this patch:
Assignee | ||
Updated•4 years ago
|
Comment 13•4 years ago
|
||
Comment on attachment 9181644 [details]
Bug 1650615 - Part 1 - Manually draw toolbar button backgrounds on Big Sur r?mstange!
approved for 78.5
Updated•4 years ago
|
Comment 14•4 years ago
|
||
bugherder uplift |
Comment 15•4 years ago
|
||
Verified with the above linked (78.5)ESR build and 83.0b10 on Release Candidate - macOS(11.0.1) Beta.
- lines are looking ok;
- no background issues for the library items and menus.
Description
•