Closed
Bug 1650638
Opened 6 years ago
Closed 6 years ago
Remove EN_US_OR_L10N_FILE macro from SeaMonkey build files.
Categories
(SeaMonkey :: Build Config, task, P3)
SeaMonkey
Build Config
Tracking
(seamonkey2.53 unaffected, seamonkey2.57esr? affected)
RESOLVED
FIXED
seamonkey 2.77
| Tracking | Status | |
|---|---|---|
| seamonkey2.53 | --- | unaffected |
| seamonkey2.57esr | ? | affected |
People
(Reporter: frg, Assigned: frg)
References
Details
Attachments
(2 files)
|
1016 bytes,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
|
1.07 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
EN_US_OR_L10N_FILE is no longer used after bug 1300198
The use was removed in:
https://hg.mozilla.org/comm-central/rev/cc85a33a585d
2.53 is not affected because the macro was originally part of mozilla-central and only removed later in bug 1439742.
| Assignee | ||
Comment 1•6 years ago
|
||
Not much of a bug
Attachment #9161483 -
Flags: review?(iann_bugzilla)
Attachment #9161483 -
Flags: approval-comm-esr60?
| Assignee | ||
Comment 2•6 years ago
|
||
Same macro as in suite and dead too as far as I see it. Not tested.
Attachment #9161485 -
Flags: review?(mkmelin+mozilla)
Updated•6 years ago
|
Attachment #9161485 -
Flags: review?(mkmelin+mozilla) → review+
Comment on attachment 9161483 [details] [diff] [review]
1650638-enusmacro-257.patch
LGTM r/a=me
Attachment #9161483 -
Flags: review?(iann_bugzilla)
Attachment #9161483 -
Flags: review+
Attachment #9161483 -
Flags: approval-comm-esr60?
Attachment #9161483 -
Flags: approval-comm-esr60+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/cd97527349e4
Remove unused EN_US_OR_L10N_FILE macro from suite. r=IanN
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/2823367d6cc6
Remove unused EN_US_OR_L10N_FILE macro from mail. r=mkmelin DONTBUILD
| Assignee | ||
Comment 6•6 years ago
|
||
Target for mail part TB 80a1.
Target Milestone: --- → seamonkey 2.77
You need to log in
before you can comment on or make changes to this bug.
Description
•