1650692 - Let GeckoView be used to decode SVG images

Status: UNCONFIRMED

(GeckoView :: General, enhancement, P3)

Description

[Tiger Oakes]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:80.0) Gecko/20100101 Firefox/80.0

Steps to reproduce:

We'd like to be able to decode SVG favicons in Android Components/Fenix

Actual results:

Currently we cannot support SVG. This causes some compat issues as sites are moving to only SVG icons now that its support in Chrome and Firefox desktop. As an example twitter had a mask icon in its list: abs.twimg.com/responsive-web/web/icon-svg.9e211f626ec9d2812.svg

AC issue: https://github.com/mozilla-mobile/android-components/issues/2081

Expected results:

GeckoView provides some API so that embedders can use it to render an SVG. It looks like the ImageDecoder class is exactly what we want, but its currently not public.

Comment 1

[Tiger Oakes]

Attachment: Bug 1650692 - ImageDecoder improvements, r=agi

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0ff30e1d830
ImageDecoder improvements, r=agi,geckoview-reviewers,snorp

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for toolchains failures on ImageDecoderTest.kt

backout: https://hg.mozilla.org/integration/autoland/rev/d4c6cd2e13bb057eb4d5f8c579f440936bf17241

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=CUogTfRuTrOemQ28T7lMMg.0&searchStr=toolchains%2Copt%2Ctoolchain%2Cbuilds%2Cfor%2Clinux%2C64-bits%2Ctoolchain-linux64-android-gradle-dependencies%2Cgradle-dependencies&revision=d0ff30e1d8301a84ef672115a0e8694a6c0fba16

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309816104&repo=autoland&lineNumber=1074

[task 2020-07-15T04:35:13.261Z] 2:34.68 > Task :geckoview:compileWithGeckoBinariesDebugAndroidTestKotlin
[task 2020-07-15T04:35:13.261Z] 2:34.68 e: /builds/worker/workspace/build/src/mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/ImageDecoderTest.kt: (32, 9): Unresolved reference: ImageDecoder
[task 2020-07-15T04:35:13.261Z] 2:34.68 /builds/worker/workspace/build/src/mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/ImageDecoderTest.kt:32:9: error: Unresolved reference: ImageDecoder
[task 2020-07-15T04:35:13.261Z] 2:34.68 e: /builds/worker/workspace/build/src/mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/ImageDecoderTest.kt: (40, 9): Unresolved reference: ImageDecoder

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:tigeroakes, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Clear needinfos that are pending on inactive users.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit auto_nag documentation.

Comment 6

[Chris Peterson [:cpeterson]]

Tasks and enhancements should have severity N/A.