1650761 - Create separate WebExtension and Policy objects to handle different types of Search Engines

Status: RESOLVED WORKSFORME

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

Following on from splitting out OpenSearchEngine from SearchEngine, I think it would be worth splitting out WebExtension and Policy engines into their own objects, at least for clarity.

The core SearchEngine class would then be used to only manage the general interfaces for getting search queries, information about the engine itself.

WebExtension/OpenSearch/Policy classes would look after initialisation, loading from cache etc.

The WebExtension and Policy setup routes currently use the same parameter types, so we may want an intermediate sub-class for those, or it may be worth simplifying the Policy set-up route completely.

When doing this we should:

• Separate out the classes
• Use the different classes when loading the engines.
• Use the different classes when loading the engines from the cache (xref bug 1650760).
• Sort out shortName handling, so that we're not setting it in the constructor and then overriding it in init.

Comment 1

[Mark Banner (:standard8)]

We've done this split in a few bugs.