1650786 - Stop using a background taskqueue with ImageBridgeChild

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Jean-Yves Avenard [:jya]]

ImageBridgeChild thread is used for sync-dispatch by the CompositableClient and others.
A background taskqueue is using a threadpool made of a single thread.

This means that no consumers of CompositableClient (e.g. anything dealing with images) can be using a background taskqueue while the ImageBridgeChild itself is using a background taskqueue (see bug 1650352).

Until bug 1650352 is resolved; it's better to have the ImageBridgeChild use a nsThread instead; reverting the changes done in bug 1647628

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1650786 - Make ImageBridgeChild use a nsThread. r=KrisWright!,mattwoodrow!

This is a partial revert of bug 1647628.

The ImageBridgeChild's thread is used to dispatch synchronous tasks by its consumers.
While the background taskqueue is using a single thread threadpool, this would prevent many places to also use a background taskqueue that could end up calling the ImageBridgeChild.

Additionally, we simplify the ShutdownStep1, ShutdownStep2 and fully shutdown the thread in order to remove a thread leak (as there would be a cycle with the nsThreadManager)

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1647628

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac98e1037321
Make ImageBridgeChild use a nsThread. r=KrisWright,mattwoodrow

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/ac98e1037321