1650787 - Implement the JWE metric type

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, enhancement, P1)

Description

[Michael Droettboom [:mdroettboom]]

Now that bug 1634468 is approved, we can proceed with the implementation as designed in the document

Comment 1

[Beatriz Rizental [:brizental]]

How far should I go with the validation for each element of the JWE? What I am checking right now:

1. I check the whole value has 5 elements separated by . (thus, I also check that we have 4 .);
2. I check that each element has a maximum of 1024 characters;
3. I check that each element is valid BASE64URL.

With this, a string such as "...." validates correctly, which doesn't seem right. Or is that good enough?

Should I be validating each field separately, each having it's own constraints?

Comment 2

[Alessio Placitelli [:Dexter]]

(In reply to Beatriz Rizental from comment #1)

With this, a string such as "...." validates correctly, which doesn't seem right. Or is that good enough?

I believe that the JWE spec does not allow for all the fields to be empty. If that's the case, I'd only add a check for that.

Comment 3

[Beatriz Rizental [:brizental]]

If I understand the spec correctly, only header and cipher_text must not be empty. I'll add a check for that.

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/glean/pull/1062

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/glean/pull/1073

Comment 6

[Beatriz Rizental [:brizental]]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/glean_parser/pull/201

Comment 7

[Beatriz Rizental [:brizental]]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/glean_parser/pull/201

Comment 8

[Beatriz Rizental [:brizental]]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/glean/pull/1087