1650819 - Measure how often the Address Bar handleNavigation fallback path is hit

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P3)

Description

[Marco Bonardo [:mak]]

We may want to measure how often the fallback path is hit, since that means we were unable to run a proper search against the profile.

Comment 1

[dong]

Attachment: Bug 1650819 - added telemetry event to count # of times handleNavigation fallback is hit. r?standard8

Comment 2

[dong]

Attachment: Bug 1650819 - added telemetry event to count # of times handleNavigation fallback is hit. r?standard8

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8f8db96614a
added telemetry event to count # of times handleNavigation fallback is hit. r=Standard8,urlbar-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c070a9d6e5b5
Revert "Bug 1650819 - added telemetry event to count # of times handleNavigation fallback is hit. r=Standard8,urlbar-reviewers" for causing bc failures on browser_urlbar_telemetry_heuristic.js.

Comment 5

[Iulian Moraru]

Revert for causing bc failures on browser_urlbar_telemetry_heuristic.js.

• Push with failures

• Failure log

• Backout link

[task 2025-05-28T16:44:40.573Z] 16:44:40     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_urlbar_telemetry_heuristic.js | Clipboard has the given value: 'test' - 
[task 2025-05-28T16:44:40.573Z] 16:44:40     INFO - Buffered messages finished
[task 2025-05-28T16:44:40.574Z] 16:44:40     INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_urlbar_telemetry_heuristic.js | Uncaught exception in test bound test_pasteAndGo_heuristicResultMissingNoStub - at chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_urlbar_telemetry_heuristic.js:49 - TypeError: can't access property "closest", menuitem is null
[task 2025-05-28T16:44:40.574Z] 16:44:40     INFO - Stack trace:
[task 2025-05-28T16:44:40.574Z] 16:44:40     INFO - test_pasteAndGo_heuristicResultMissingNoStub@chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_urlbar_telemetry_heuristic.js:49:3
[task 2025-05-28T16:44:40.574Z] 16:44:40     INFO - async*handleTask@chrome://mochikit/content/browser-test.js:1170:26
[task 2025-05-28T16:44:40.574Z] 16:44:40     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1242:18
[task 2025-05-28T16:44:40.574Z] 16:44:40     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1383:14
[task 2025-05-28T16:44:40.574Z] 16:44:40     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1159:14
[task 2025-05-28T16:44:40.574Z] 16:44:40     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13
[task 2025-05-28T16:44:40.575Z] 16:44:40     INFO - Leaving test bound test_pasteAndGo_heuristicResultMissingNoStub
[task 2025-05-28T16:44:40.575Z] 16:44:40     INFO - Entering test bound test_pasteAndGo_heuristicResultMissing
[task 2025-05-28T16:44:40.575Z] 16:44:40     INFO - Initializing clipboard with "waitForClipboard-known-value-0.21877440243509383"...
[task 2025-05-28T16:44:40.576Z] 16:44:40     INFO - Succeeded initializing clipboard, start requested things...
[task 2025-05-28T16:44:40.576Z] 16:44:40     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_urlbar_telemetry_heuristic.js | Clipboard has the given value: 'test' - 

Comment 6

[dong]

Resolved, see here

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/07a232785c50
https://hg.mozilla.org/integration/autoland/rev/6d1c35f16016
added telemetry event to count # of times handleNavigation fallback is hit. r=Standard8,urlbar-reviewers

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/6d1c35f16016