Closed Bug 1650848 Opened 5 years ago Closed 5 years ago

Make test_bug1151663.html better test what it's supposed to be testing

Categories

(Core :: Panning and Zooming, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file)

The helper file sets overflow:scroll on the body and adds a spacer div to ensure the root scrollframe is scrollable.

But if you load this helper page in a browser, it doesn't actually render as you might expect if that <body> tag were a <div>. The <body> tag has magical behaviour and this page actually only has a scrollable root scroller if the browser height is less than 1000px. On android the page is rendered zoomed out and it actually is not scrollable, so this test is not testing what it's supposed to be testing.

With WIP patches I have for bug 1621740 this test ends up failing because it detects the root scrollframe as non-scrollable, and then makes the div the "primary scrollframe" which it isn't supposed to.

The body tag has special behaviour and this page doesn't behave as one might
expect if the body tag were a div, for example. The root scroller here is still
the html element, and if the browser window is taller than 1000px it's not
considered scrollable. And on Android, with the initial-scale that gets applied,
the root scroller is actually not scrollable. This patch fixes it to ensure the
root scroller is actually scrollable in testing scenarios.

Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/46170808175a Make the root scroller actually scrollable in the test. r=botond
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: