1650880 - Alias from webExtensions only work on install, not subsequent browser restarts

Status: RESOLVED FIXED

(Firefox :: Search, defect, P4)

Description

[Dale Harvey (:daleharvey)]

We dont store the alias in the cache so dont restore it when reloading engines from cache

Comment 2

[Dale Harvey (:daleharvey)]

Attachment: Bug 1650880 - Persist the engines alias in cache. r?Standard8

Comment 3

[Dale Harvey (:daleharvey)]

Attachment: Bug 1650880 - Refactor toJSON in SearchEngine.jsm. r?Standard8

Depends on D84390

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0fb59851d956
Persist the engines alias in cache. r=Standard8
https://hg.mozilla.org/integration/autoland/rev/103d388bac74
Refactor toJSON in SearchEngine.jsm. r=Standard8

Comment 5

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1650880) for XPCshell failures in components/search/tests/xpcshell/test_engine_alias.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=310867063&repo=autoland&lineNumber=3099

Push with failure:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=103d388bac7473c617ddf3c6794ee7651ff86422

Backout:
https://hg.mozilla.org/integration/autoland/rev/ee66b0925c55401bb7fd5e7eaa8db772ec16ed0c

Comment 6

[Dale Harvey (:daleharvey)]

Ok the logs make it look like a race cache which would explain why its intermittent, updated to avoid that and looks like I cant see the error from a whole bunch of runs @ https://treeherder.mozilla.org/#/jobs?repo=try&revision=e7f401fe7b05bc90216a73a3deea467fe454510d

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dad0085e266d
Persist the engines alias in cache. r=Standard8
https://hg.mozilla.org/integration/autoland/rev/229757cf5a2d
Refactor toJSON in SearchEngine.jsm. r=Standard8

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/dad0085e266d
https://hg.mozilla.org/mozilla-central/rev/229757cf5a2d