1650881 - Make webExtensions support multiple aliases

Status: RESOLVED FIXED

(Firefox :: Search, enhancement, P4)

Description

[Dale Harvey (:daleharvey)]

We use multiple aliases for yandex + baidu, if we want to use webExtension keywords here we need to add support for multiples

Comment 1

[Dale Harvey (:daleharvey)]

Attachment: Bug 1650881 - Support multiple aliases in webextensions

Comment 2

[Dale Harvey (:daleharvey)]

Hey Shane

This is regarding the search_provider.keyword field being able to handle multiple aliases. Mark and I were wondering, the first implementation of this I just pass through the keyword field and split the string on spaces. So search_provider.keyword = "@duckduckgo @ggd" This makes it simple not having to touch webextensions code, but obviously a little unclean to be doing string operations.

Another choice would be to have the webextensions field support both strings as it does now, and an array search_provider.keyword = ["@duckduckgo", "@ddg"]

Do you have strong opinions either way?

Cheers
Dale

Comment 3

[Shane Caraveo (:mixedpuppy)]

Using an array would probably be the cleaner path here.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c2dbabf8715
Support multiple aliases in webextensions r=Standard8,mixedpuppy

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/3c2dbabf8715

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6b8097f6f11c
Port bug 1650881 - Support multiple aliases in search webextensions. rs=bustage-fix