1650931 - Preferences/Options > General > Tabs > Containers > Settings... doesn't open container settings anymore

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox Nightly 80.0a1 on Windows 8.1

Preferences/Options > General > Tabs > Containers > Settings... doesn't open container settings anymore.

This started with the change for bug 1648222.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1650931 - don't use hidden attribute to hide the containers category item, so switching to it works correctly, r?mconley

In bug 1648222, the gotoPref helper that switches between different
preference panes was altered to disallow switching to hidden categories, so
that if there were no experimental pref entries, we don't show the
'Firefox experiments' category in the prefs.

Unfortunately, the containers category is always hidden, and only accessible
from the 'settings' button for containers and the URL (ie
about:preferences#containers), but the added requirement for categories to
not have the hidden attribute broke showing this category.

This patch fixes this by hiding the category using CSS instead. It also
cleans up some other use of the hidden attribute.

Note that the sync category is also hidden by default, but shown at
https://searchfox.org/mozilla-central/rev/91d82d7cbf05a71954dfa49d0e43824c7c973e62/browser/components/preferences/preferences.js#97-103

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/940cb5bf5cfc
don't use hidden attribute to hide the containers category item, so switching to it works correctly, r=preferences-reviewers,mstriemer

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/940cb5bf5cfc

Comment 4

[Anca Soncutean, Desktop QA]

Reproduced with Fx 80.0a1 (2020-07-06) on Windows 10.
Verified fixed with Fx 81.0a1 (2020-08-10) (default) and Fx 80.0b6 (Firefox Multi-Account Containers add-on enabled) on Windows 10 and Ubuntu 18.04.